From: Mike Christie <michaelc@cs.wisc.edu>
To: kxie@chelsio.com
Cc: netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
open-iscsi@googlegroups.com, rranjan@chelsio.com,
James.Bottomley@HansenPartnership.com, davem@davemloft.net
Subject: Re: [PATCH] cxgbi: bug fixes and code cleanup
Date: Wed, 22 Sep 2010 15:09:33 -0500 [thread overview]
Message-ID: <4C9A627D.4060800@cs.wisc.edu> (raw)
In-Reply-To: <201009211609.o8LG9HPm014568@localhost.localdomain>
On 09/21/2010 11:09 AM, kxie@chelsio.com wrote:
> [PATCH] cxgbi: bug fixes and code cleanup
>
> From: Karen Xie<kxie@chelsio.com>
>
> The patch includes the following changes.
> - removed un-used code
> - renamed alloc_cpl() to alloc_wr().
> - fixed connecting over VLAN.
> - updated cxgb4i connection setting and pagepod programming.
Could you break up the patch into a patch per change next time?
> - read_lock(&csk->callback_lock);
> dskb = skb_peek(&csk->receive_queue);
> if (!dskb) {
> read_unlock(&csk->callback_lock);
I think you also have to remove this read_unlock call.
next prev parent reply other threads:[~2010-09-22 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 16:09 [PATCH] cxgbi: bug fixes and code cleanup kxie-ut6Up61K2wZBDgjK7y7TUQ
2010-09-22 20:09 ` Mike Christie [this message]
2010-09-22 20:52 ` Karen Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9A627D.4060800@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=davem@davemloft.net \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=rranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).