From: Tejun Heo <htejun@gmail.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Roland Dreier <rdreier@cisco.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-kernel@vger.kernel.org, "Jean Delvare (PC drivers,
core)" <khali@linux-fr.org>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
Roland Dreier <rolandd@cisco.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Steve Wise <swise@chelsio.com>, Neil Brown <neilb@suse.de>,
Paul Mackerras <paulus@samba.org>,
linux-i2c@vger.kernel.org, linux-rdma@vger.kernel.org,
dm-devel@redhat.com, linux-raid@vger.kernel.org,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: idr_get_new_exact ?
Date: Thu, 23 Sep 2010 13:46:29 +0200 [thread overview]
Message-ID: <4C9B3E15.5080002@gmail.com> (raw)
In-Reply-To: <20100923114255.GB27960@linux-sh.org>
Hello,
On 09/23/2010 01:42 PM, Paul Mundt wrote:
> On Mon, Sep 20, 2010 at 11:26:47PM +0200, Tejun Heo wrote:
>> Hello,
>>
>> On 09/20/2010 10:35 PM, Roland Dreier wrote:
>>> Looks fine to me as an improvement over the status quo, but I wonder how
>>> many of these places could use the radix_tree stuff instead? If you're
>>> not using the ability of the idr code to assign an id for you, then it
>>> seems the radix_tree API is a better fit.
>>
>> I agree. Wouldn't those users better off simply using radix tree?
>>
> It could go either way. I was about to write the same function when
> playing with it for IRQ mapping, the idea being to propagate the initial
> tree with sparse static vectors and then switch over to dynamic IDs for
> virtual IRQ creation. I ended up going with a radix tree for other
> reasons, though.
I see. If there are use cases where fixed and dynamic IDs need to be
mixed, no objection from me.
Thanks.
--
tejun
prev parent reply other threads:[~2010-09-23 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 14:11 idr_get_new_exact ? Ohad Ben-Cohen
[not found] ` <AANLkTi=ZLupVyFR0e2v-TLpeNWdw1bVMZUAhgyxLJ7OV-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-20 19:31 ` Andrew Morton
[not found] ` <20100920123140.f524de79.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-09-20 20:07 ` Steve Wise
2010-09-20 20:35 ` Roland Dreier
2010-09-20 21:26 ` Tejun Heo
2010-09-20 21:38 ` [dm-devel] " Alasdair G Kergon
[not found] ` <4C97D197.9070703-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-09-23 11:42 ` Paul Mundt
2010-09-23 11:46 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9B3E15.5080002@gmail.com \
--to=htejun@gmail.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=dm-devel@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=khali@linux-fr.org \
--cc=lethal@linux-sh.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=paulus@samba.org \
--cc=rdreier@cisco.com \
--cc=rolandd@cisco.com \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).