public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: didier <did447@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: VLAN GARP triggers a lot of timers if linux compiled with VLAN_8021Q_GVRP
Date: Wed, 29 Sep 2010 11:22:51 +0200	[thread overview]
Message-ID: <4CA3056B.6010901@trash.net> (raw)
In-Reply-To: <AANLkTinZ_6+PzAHHc5vaY+H2iX_pf4vsdNsnZ2_N7EDf@mail.gmail.com>

Am 29.09.2010 02:35, schrieb didier:
> Hi,
> 
> In my understanding GARP is using a periodic timer but in net/802/garp.c:
> 
> garp_join_timer_arm()
> 
> delay = (u64)msecs_to_jiffies(garp_join_time)* net_random() >> 32;
> mod_timer(&app->join_timer, jiffies +delay)
> 
> Isn't this stuff triggering a *lot* of events?

Yeah, something around 5-10 timers per second IIRC. There was an RFC
patch a while ago to only schedule the timer on-demand, I'll see
whether I can find it again.

  reply	other threads:[~2010-09-29  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29  0:35 VLAN GARP triggers a lot of timers if linux compiled with VLAN_8021Q_GVRP didier
2010-09-29  9:22 ` Patrick McHardy [this message]
2010-09-29 11:02   ` didier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA3056B.6010901@trash.net \
    --to=kaber@trash.net \
    --cc=did447@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox