* [PATCH] ehea: simplify conditional
@ 2010-10-07 23:14 Nicolas Kaiser
2010-10-07 23:49 ` Breno Leitao
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Kaiser @ 2010-10-07 23:14 UTC (permalink / raw)
To: Breno Leitao; +Cc: netdev, linux-kernel
Simplify: ((a && b) || (!a && !b)) => (a == b)
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/net/ehea/ehea_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index 190fb69..ef305f3 100644
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -1914,7 +1914,7 @@ static void ehea_promiscuous(struct net_device *dev, int enable)
struct hcp_ehea_port_cb7 *cb7;
u64 hret;
- if ((enable && port->promisc) || (!enable && !port->promisc))
+ if (enable == port->promisc)
return;
cb7 = (void *)get_zeroed_page(GFP_ATOMIC);
--
1.7.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ehea: simplify conditional
2010-10-07 23:14 [PATCH] ehea: simplify conditional Nicolas Kaiser
@ 2010-10-07 23:49 ` Breno Leitao
2010-10-09 16:21 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Breno Leitao @ 2010-10-07 23:49 UTC (permalink / raw)
To: Nicolas Kaiser; +Cc: netdev, linux-kernel
On 10/07/2010 08:14 PM, Nicolas Kaiser wrote:
> Simplify: ((a&& b) || (!a&& !b)) => (a == b)
>
> Signed-off-by: Nicolas Kaiser<nikai@nikai.net>
Acked-by: Breno Leitao <leitao@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ehea: simplify conditional
2010-10-07 23:49 ` Breno Leitao
@ 2010-10-09 16:21 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-10-09 16:21 UTC (permalink / raw)
To: leitao; +Cc: nikai, netdev, linux-kernel
From: Breno Leitao <leitao@linux.vnet.ibm.com>
Date: Thu, 07 Oct 2010 20:49:05 -0300
> On 10/07/2010 08:14 PM, Nicolas Kaiser wrote:
>> Simplify: ((a&& b) || (!a&& !b)) => (a == b)
>>
>> Signed-off-by: Nicolas Kaiser<nikai@nikai.net>
> Acked-by: Breno Leitao <leitao@linux.vnet.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-09 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-07 23:14 [PATCH] ehea: simplify conditional Nicolas Kaiser
2010-10-07 23:49 ` Breno Leitao
2010-10-09 16:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).