From: "Timo Teräs" <timo.teras@iki.fi>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: synchronize bind() with RTM_NEWADDR notifications
Date: Thu, 21 Oct 2010 14:57:51 +0300 [thread overview]
Message-ID: <4CC02ABF.8090008@iki.fi> (raw)
In-Reply-To: <20101021.043421.108778257.davem@davemloft.net>
On 10/21/2010 02:34 PM, David Miller wrote:
> From: Timo Teräs <timo.teras@iki.fi>
> Date: Thu, 21 Oct 2010 14:29:22 +0300
>
>> This is the third time asking, what would be a good way to fix the
>> problem described in the original commit log?
>
> I kept your report in my inbox backlog and intended to think about
> it as time permitted.
>
> As the merge window has just openned up, for me time will not be
> "permitted" for some time.
Fair enough. Just getting multiple "does not work" without single
mention of "will think about this later" felt frustrating.
I have one more alternative: Would it be acceptable if we did
rtnl_lock()/rtnl_unlock() only if inet_addr_type() earlier said the
address is unacceptable for binding. And then retry inet_addr_type(). Or
do you think that the error case EADDRNOTAVAIL is a hot path too?
next prev parent reply other threads:[~2010-10-21 11:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 10:12 [PATCH] ipv4: synchronize bind() with RTM_NEWADDR notifications Timo Teräs
2010-10-21 10:25 ` Eric Dumazet
2010-10-21 10:41 ` Timo Teräs
2010-10-21 10:50 ` David Miller
2010-10-21 10:58 ` Timo Teräs
2010-10-21 11:03 ` David Miller
2010-10-21 11:29 ` Timo Teräs
2010-10-21 11:34 ` David Miller
2010-10-21 11:57 ` Timo Teräs [this message]
2010-10-21 13:06 ` [PATCH v2] " Timo Teräs
2010-10-21 14:10 ` Eric Dumazet
2010-10-21 19:01 ` Timo Teräs
2010-10-21 11:12 ` [PATCH] " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC02ABF.8090008@iki.fi \
--to=timo.teras@iki.fi \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).