* Question on code in __netif_receive_skb
@ 2010-10-25 21:37 Ben Greear
0 siblings, 0 replies; only message in thread
From: Ben Greear @ 2010-10-25 21:37 UTC (permalink / raw)
To: NetDev; +Cc: Patrick McHardy, Eric Dumazet
While poking at the VLAN crash, I noticed this code in dev.c, in
the __netif_receive_skb method.
if (vlan_tx_tag_present(skb) && vlan_hwaccel_do_receive(skb))
return NET_RX_SUCCESS;
As far as I can tell, this return can never happen because vlan_hwaccel_do_receive
always returns 0.
Maybe it should instead check for return-value == 0 and return success in that case?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-10-25 21:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-25 21:37 Question on code in __netif_receive_skb Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).