From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Kirjanov Subject: Re: Fwd: NULL pointer dereference at netxen_nic_probe+0x813/0x9a0 Date: Fri, 29 Oct 2010 23:47:22 +0400 Message-ID: <4CCB24CA.3050106@kernel.org> References: <201010281250.50802.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: amit.salecha@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: bjorn.helgaas@hp.com Return-path: Received: from hera.kernel.org ([140.211.167.34]:37406 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761580Ab0J2Tq7 (ORCPT ); Fri, 29 Oct 2010 15:46:59 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > This is on current Linus upstream as of this morning (8128057) > on an HP DL785: > > QLogic/NetXen Network Driver v4.0.74 > netxen_nic 0000:07:00.0: PCI INT A -> GSI 30 (level, low) -> IRQ 30 > netxen_nic 0000:07:00.0: setting latency timer to 64 > netxen_nic 0000:07:00.0: 2MB memory map > netxen_nic 0000:07:00.0: loading firmware from flash > netxen_nic 0000:07:00.0: using 64-bit dma mask > kernel: Quad Gig LP Board S/N TI9ABK0266 Chip rev 0x42 > netxen_nic 0000:07:00.0: firmware v4.0.520 [legacy] > netxen_nic 0000:07:00.0: irq 72 for MSI/MSI-X > netxen_nic 0000:07:00.0: irq 73 for MSI/MSI-X > netxen_nic 0000:07:00.0: irq 74 for MSI/MSI-X > netxen_nic 0000:07:00.0: irq 75 for MSI/MSI-X > netxen_nic 0000:07:00.0: using msi-x interrupts > BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 > IP: [] netxen_nic_probe+0x813/0x9a0 > PGD 0 > Oops: 0002 [#1] SMP > last sysfs file: > CPU 0 > Modules linked in: > > Pid: 1650, comm: work_for_cpu Not tainted 2.6.36-07338-g8128057 #269 > /ProLiant DL785 G5 > RIP: 0010:[] [] > netxen_nic_probe+0x813/0x9a0 > RSP: 0018:ffff8806138abe30 EFLAGS: 00010246 > RAX: 0000000000000010 RBX: ffff8806139126c0 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: ffff880613895616 RDI: ffff880613912000 > RBP: ffff8806138abe90 R08: 0000000000000000 R09: ffff8806138abb80 > R10: 0000000000000000 R11: 0000000000000000 R12: ffff880613912000 > R13: ffff8812174f7000 R14: ffff880613912000 R15: ffff8812174f7000 > FS: 0000000000000000(0000) GS:ffff8800cfa00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b > CR2: 0000000000000010 CR3: 0000000001c07000 CR4: 00000000000006f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 > Process work_for_cpu (pid: 1650, threadinfo ffff8806138aa000, task > ffff880616f12be0) > Stack: > ffff8812174f7090 0000000000000246 ffff8806138abe90 ffff8812174f7000 > 00008806138abfd8 0000000000000282 68cd0025b30068cc ffff880c17439d30 > ffff8812174f7090 ffff8812174f7000 ffff8812174f7208 0000000000000000 > Call Trace: > [] local_pci_probe+0x48/0x91 > [] ? do_work_for_cpu+0x0/0x26 > [] do_work_for_cpu+0x13/0x26 > [] ? do_work_for_cpu+0x0/0x26 > [] kthread+0x81/0x89 > [] kernel_thread_helper+0x4/0x10 > [] ? kthread+0x0/0x89 > [] ? kernel_thread_helper+0x0/0x10 > Code: 00 eb 15 49 8d bf 90 00 00 00 48 c7 c6 1b 2e aa 81 31 c0 e8 c0 > 4e cd ff 4c 89 f7 e8 d6 bb ee ff 49 8b 96 00 03 00 00 48 8d 42 10 > 80 4a 10 01 4c 89 f7 e8 a3 7e ed ff 85 c0 41 89 c4 74 2a 49 > RIP [] netxen_nic_probe+0x813/0x9a0 > RSP > CR2: 0000000000000010 > ---[ end trace 059c7071bbf8de1f ]--- Could you please try the following patch. diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index 50820be..5766475 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c @@ -1239,15 +1239,15 @@ netxen_setup_netdev(struct netxen_adapter *adapter, if (netxen_read_mac_addr(adapter)) dev_warn(&pdev->dev, "failed to read mac addr\n"); - netif_carrier_off(netdev); - netif_stop_queue(netdev); - err = register_netdev(netdev); if (err) { dev_err(&pdev->dev, "failed to register net device\n"); return err; } + netif_carrier_off(netdev); + netif_stop_queue(netdev); + return 0; }