From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: linux1394-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] firewire: net: rate-limit log spam at transmit failure
Date: Mon, 08 Nov 2010 09:12:43 +0100 [thread overview]
Message-ID: <4CD7B0FB.8090901@s5r6.in-berlin.de> (raw)
In-Reply-To: <1289180517.4318.3.camel@maxim-laptop>
Maxim Levitsky wrote:
> But why the timeout is never set?
It is set to the default 0.1s per IEEE 1394 in core-card.c::fw_card_initialize.
If card->split_timeout_jiffies or card->split_timeout_cycles /ever/ become
zero, then only due to a memory corrupting bug.
> Also, note that I see here that if I send a TCP stream from one system
> to another then the system that recieves the packets (and sends TCP
> acks), still overflows the queue (error 10, and confirmed by printks).
OK, I'll send a stricter version of "firewire: net: throttle TX queue before
running out of tlabels".
--
Stefan Richter
-=====-==-=- =-== -=---
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-11-08 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tkrat.01ca17fba0508ae0@s5r6.in-berlin.de>
[not found] ` <tkrat.1b9925fa1d199c23@s5r6.in-berlin.de>
[not found] ` <tkrat.18b9f67ac78dcbea@s5r6.in-berlin.de>
[not found] ` <tkrat.276aeae22ec60090@s5r6.in-berlin.de>
2010-11-07 3:26 ` [PATCH] firewire: net: rate-limit log spam at transmit failure Maxim Levitsky
2010-11-07 3:32 ` Maxim Levitsky
2010-11-07 12:03 ` Stefan Richter
2010-11-08 1:41 ` Maxim Levitsky
2010-11-08 8:12 ` Stefan Richter [this message]
2010-11-07 11:10 ` Stefan Richter
2010-11-07 12:04 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD7B0FB.8090901@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=maximlevitsky@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).