From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH net-next-2.6 v2] can: Topcliff: PCH_CAN driver: Fix build warnings Date: Thu, 11 Nov 2010 11:04:39 +0100 Message-ID: <4CDBBFB7.70806@pengutronix.de> References: <005301cb7ffa$5b63cd90$66f8800a@maildom.okisemi.com> <00fe01cb8009$62e11410$66f8800a@maildom.okisemi.com> <4CD945B4.4060408@pengutronix.de> <002501cb8186$b56a6280$66f8800a@maildom.okisemi.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6782737796166383542==" Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Masayuki Ohtake , Samuel Ortiz , margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Wolfgang Grandegger , joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, "David S. Miller" , Christian Pellegrin , qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org To: Tomoya MORINAGA Return-path: In-Reply-To: <002501cb8186$b56a6280$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============6782737796166383542== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEAC1BD5DD8E5F0D1A31083FD" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEAC1BD5DD8E5F0D1A31083FD Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: quoted-printable On 11/11/2010 10:56 AM, Tomoya MORINAGA wrote: >>>>> + if (priv->tx_obj =3D=3D (PCH_OBJ_NUM + 1)) { /* Point tail Obj + = 1 */ >>>>> + while (ioread32(&priv->regs->treq2) & 0xfc00) >>>>> + udelay(1); >>> >>> When points tail of Tx message object, >>> this driver waits until completion of all tx messaeg objects. >> >> Looping busy it not an option here. >> >>> Thus, application/driver ought not to be able to put Tx object exceed= the number of tx message object. >>> Thus I think these code(netif_stop_queue/netif_wake_queue) are comple= tely redundant. >> >> Nope - please remove the waiting completely and convert your flow >> control to netif_stop_queue/netif_wake_queue. >> >=20 > I see. > I will remove like above. >=20 > BTW, Let me know the reason. > Could you explain the reason why you deny looping busy loop ? That would kill performance. cheers, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enigEAC1BD5DD8E5F0D1A31083FD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkzbv7sACgkQjTAFq1RaXHMUsgCfU4InjhlY4IYTO5xwHD6wOOQk 12kAn291ha7SfRpl2bC5KWVJe8L+EQsH =jGR6 -----END PGP SIGNATURE----- --------------enigEAC1BD5DD8E5F0D1A31083FD-- --===============6782737796166383542== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Socketcan-core mailing list Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org https://lists.berlios.de/mailman/listinfo/socketcan-core --===============6782737796166383542==--