From: John Fastabend <john.r.fastabend@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "therbert@google.com" <therbert@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>
Subject: Re: [net-2.6 PATCH] nete zero kobject in rx_queue_release
Date: Mon, 15 Nov 2010 18:06:52 -0800 [thread overview]
Message-ID: <4CE1E73C.1000105@intel.com> (raw)
In-Reply-To: <20101114.151529.183053743.davem@davemloft.net>
On 11/14/2010 3:15 PM, David Miller wrote:
> From: Tom Herbert <therbert@google.com>
> Date: Sun, 14 Nov 2010 14:40:00 -0800
>
>>> So we'll need something like:
>>>
>>> if (atomic_dec_and_test(&first->count))
>>> kfree(first);
>>> else
>>> /* clear everything except queue->first */
>>>
>>
>> The patches to get rid of the separate refcnt should obviate this
>> complexity. Could just clear the queue in kobject release.
>
> True but we'll still need a patch for older kernels.
OK Thanks. I'll have a stable patch and a net-2.6 patch soon.
-- John
next prev parent reply other threads:[~2010-11-16 2:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 20:13 [net-2.6 PATCH] nete zero kobject in rx_queue_release John Fastabend
2010-11-12 21:08 ` David Miller
2010-11-14 22:40 ` Tom Herbert
2010-11-14 23:15 ` David Miller
2010-11-16 2:06 ` John Fastabend [this message]
2010-11-16 7:13 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE1E73C.1000105@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).