netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] ehea: Use the standard logging functions
Date: Tue, 30 Nov 2010 15:03:56 -0200	[thread overview]
Message-ID: <4CF52E7C.7010308@linux.vnet.ibm.com> (raw)
In-Reply-To: <1290814046.11971.320.camel@Joe-Laptop>

Joe,

Thanks for the patch. Please make sure that it applies over the last 
Davem's tree. He just committed one patch that will probably conflict 
with this patch.

Also, this patch is printing:

ibmebus port0: foobarmessage

Instead of

ehea: foobarmessage

But this is a driver issue, and your patch just exposed this problem. I 
will send a patch for this soon.

Thanks
Breno

On 11/26/2010 09:27 PM, Joe Perches wrote:
> Remove ehea_error, ehea_info and ehea_debug macros.
> Use pr_fmt, pr_<level>, netdev_<level>  and netif_<level>  as appropriate.
> Fix messages to use trailing "\n", some messages had an extra one
> as the old ehea_<level>  macros added a trailing "\n".
> Coalesced long format strings.
>
> Uncompiled/untested.
>
> Signed-off-by: Joe Perches<joe@perches.com>
Acked-by: Breno Leitao <leitao@linux.vnet.ibm.com>


  reply	other threads:[~2010-11-30 17:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-26 16:26 [PATCH] ehea: Add some info messages and fix an issue leitao
2010-11-26 17:01 ` Joe Perches
2010-11-26 17:26   ` leitao
2010-11-26 23:27     ` [PATCH] ehea: Use the standard logging functions Joe Perches
2010-11-30 17:03       ` Breno Leitao [this message]
2010-11-30 18:18         ` [net-next PATCH V2] " Joe Perches
2010-12-02 18:54           ` Breno Leitao
2010-12-06 21:02             ` David Miller
2010-11-29  2:15     ` [PATCH] ehea: Add some info messages and fix an issue David Miller
2011-01-07  3:24     ` Anton Blanchard
2011-01-07 12:14       ` Breno Leitao
  -- strict thread matches above, loose matches on Subject: below --
2010-12-09  2:39 [PATCH net-next V2] ehea: Use the standard logging functions Joe Perches
2010-12-13 14:04 ` [PATCH] " leitao
2010-12-13 18:01   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF52E7C.7010308@linux.vnet.ibm.com \
    --to=leitao@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).