From: Brian Haley <brian.haley@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] net: optimize INET input path further
Date: Wed, 01 Dec 2010 12:37:55 -0500 [thread overview]
Message-ID: <4CF687F3.7030107@hp.com> (raw)
In-Reply-To: <1291179847.2856.452.camel@edumazet-laptop>
On 12/01/2010 12:04 AM, Eric Dumazet wrote:
> struct sock_common {
> - /*
> - * first fields are not copied in sock_copy()
> + /* skc_daddr and skc_rcv_saddr must be grouped :
> + * cf INET_MATCH() and INET_TW_MATCH()
> */
> - union {
> - struct hlist_node skc_node;
> - struct hlist_nulls_node skc_nulls_node;
> - };
> - atomic_t skc_refcnt;
> - int skc_tx_queue_mapping;
> + __be32 skc_daddr;
> + __be32 skc_rcv_saddr;
>
> union {
> unsigned int skc_hash;
Putting IPv4 addresses in sock_common doesn't make it so common anymore :)
Is it possible to make this a union so other address families like IPv6
can benefit from this as well, or will that blow the whole cache line
effect you were trying to achieve?
-Brian
next prev parent reply other threads:[~2010-12-01 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 5:04 [PATCH net-next-2.6] net: optimize INET input path further Eric Dumazet
2010-12-01 17:37 ` Brian Haley [this message]
2010-12-01 17:42 ` Eric Dumazet
2010-12-01 18:00 ` Brian Haley
2010-12-03 17:11 ` David Miller
2010-12-10 4:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF687F3.7030107@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).