From: Brian Haley <brian.haley@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] net: optimize INET input path further
Date: Wed, 01 Dec 2010 13:00:21 -0500 [thread overview]
Message-ID: <4CF68D35.8020701@hp.com> (raw)
In-Reply-To: <1291225358.2856.1035.camel@edumazet-laptop>
On 12/01/2010 12:42 PM, Eric Dumazet wrote:
>> Putting IPv4 addresses in sock_common doesn't make it so common anymore :)
>>
>> Is it possible to make this a union so other address families like IPv6
>> can benefit from this as well, or will that blow the whole cache line
>> effect you were trying to achieve?
>
> This might be OK, depending on cache line size and/or arch.
>
> On x86_32 for example, that might even be a good thing, because refcnt
> might still be in the first 64bytes of socket.
>
> By the way, ipv6 sock includes inet, so includes ipv4 addresses too, I
> only moved them in the 'whole structure'
Yes, all that IPv4 address baggage is still there in an IPv6 sock, even
if not used. I haven't even looked close enough to see if it is possible
to move the IPv6 addresses since I think there are times when both are
in-use.
-Brian
next prev parent reply other threads:[~2010-12-01 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 5:04 [PATCH net-next-2.6] net: optimize INET input path further Eric Dumazet
2010-12-01 17:37 ` Brian Haley
2010-12-01 17:42 ` Eric Dumazet
2010-12-01 18:00 ` Brian Haley [this message]
2010-12-03 17:11 ` David Miller
2010-12-10 4:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF68D35.8020701@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).