From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch] bonding: clean up netpoll code Date: Thu, 02 Dec 2010 11:14:57 +0800 Message-ID: <4CF70F31.5030204@redhat.com> References: <20101201075043.5741.29172.sendpatchset@localhost.localdomain> <20101201081457.23102445@nehalam> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Jiri Pirko , Neil Horman , netdev@vger.kernel.org, "David S. Miller" , "Eric W. Biederman" , Herbert Xu , bonding-devel@lists.sourceforge.net, Jay Vosburgh To: Stephen Hemminger Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28842 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756773Ab0LBDKR (ORCPT ); Wed, 1 Dec 2010 22:10:17 -0500 In-Reply-To: <20101201081457.23102445@nehalam> Sender: netdev-owner@vger.kernel.org List-ID: On 12/02/10 00:14, Stephen Hemminger wrote: > On Wed, 1 Dec 2010 02:45:45 -0500 > Amerigo Wang wrote: > >> + if ((slave_dev->npinfo = bond_netpoll_info(bond))) { > > Split assignment and conditional into two lines > Ok, will change this in the next update. Thanks!