From: Shan Wei <shanwei@cn.fujitsu.com>
To: tgraf@infradead.org
Cc: David Miller <davem@davemloft.net>,
Network-Maillist <netdev@vger.kernel.org>,
Shan Wei <shanwei@cn.fujitsu.com>
Subject: Re: [PATCH v2 1/4] net: snmp: fix the wrong ICMP_MIB_MAX value
Date: Thu, 02 Dec 2010 18:35:50 +0800 [thread overview]
Message-ID: <4CF77686.5010305@cn.fujitsu.com> (raw)
In-Reply-To: <20101202095753.GA10221@canuck.infradead.org>
Thomas Graf wrote, at 12/02/2010 05:57 PM:
>> /* ICMP */
>> #define ICMP_MIB_DUMMY __ICMP_MIB_MAX
>> -#define ICMP_MIB_MAX (__ICMP_MIB_MAX + 1)
>> -
>> +#define ICMP_MIB_MAX __ICMP_MIB_MAX
>
> Looks like the +1 is there to account for ICMP_MIB_DUMMY. It is
> unused though but you have to remove it as well if you want to
> kill that extra +1.
I don't know the history about ICMP_MIB_DUMMY before v2.6.12-rc2.
But after that, it is abandoned.
ICMP_MIB_DUMMY is killed in patch:
［PATCH v2 4/4] net: kill unused macros from head file
--
Best Regards
-----
Shan Wei
next prev parent reply other threads:[~2010-12-02 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 4:04 [PATCH v2 1/4] net: snmp: fix the wrong ICMP_MIB_MAX value Shan Wei
2010-12-02 9:57 ` Thomas Graf
2010-12-02 10:35 ` Shan Wei [this message]
2010-12-02 10:42 ` Thomas Graf
2010-12-02 17:38 ` David Miller
2010-12-02 21:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF77686.5010305@cn.fujitsu.com \
--to=shanwei@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).