From: "Jan Beulich" <JBeulich@novell.com>
To: "David Miller" <davem@davemloft.net>
Cc: <akpm@linux-foundation.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] use total_highpages when calculating lowmem-only allocation sizes (dccp)
Date: Tue, 07 Dec 2010 14:38:21 +0000 [thread overview]
Message-ID: <4CFE54ED02000078000266AD@vpn.id2.novell.com> (raw)
In-Reply-To: <20101206.093630.104060994.davem@davemloft.net>
>>> On 06.12.10 at 18:36, David Miller <davem@davemloft.net> wrote:
> From: "Jan Beulich" <JBeulich@novell.com>
> Date: Mon, 06 Dec 2010 16:42:46 +0000
>
>> For those (large) table allocations that come only from lowmem, the
>> total amount of memory shouldn't really matter.
>>
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> Instead of continually tweaking the bits in these code paths,
> we should be converting them over to using a central routine
> such as alloc_large_system_hash() where the logic is consolidated
> _AND_ the code knows to use vmalloc() and NUMA aware allocations
> when warranted.
Hmm, not sure. For one, alloc_large_system_hash() is (and imo
ought to remain) an __init function. Second, looking at the one
non-modular case (netlink_proto_init()), I don't think using this
function would be the intention here.
Jan
next prev parent reply other threads:[~2010-12-07 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 16:42 [PATCH] use total_highpages when calculating lowmem-only allocation sizes (dccp) Jan Beulich
2010-12-06 17:36 ` David Miller
2010-12-07 14:38 ` Jan Beulich [this message]
2010-12-08 0:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE54ED02000078000266AD@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).