From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [patch] econet: unlock on -EPERM path Date: Tue, 07 Dec 2010 23:01:38 +0100 Message-ID: <4CFEAEC2.7080506@gmail.com> References: <20101207110138.GM10623@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Phil Blundell , Eric Dumazet , "David S. Miller" , kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:61794 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275Ab0LGWBr (ORCPT ); Tue, 7 Dec 2010 17:01:47 -0500 In-Reply-To: <20101207110138.GM10623@bicker> Sender: netdev-owner@vger.kernel.org List-ID: Dan Carpenter wrote: > We need to do a mutex_unlock() and a put_dev() before returning. Good catch! Btw, isn't this put_dev() below, in case SIOCGIFADDR, superfluous? Jarek P.