netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Ilya Loginov <isloginov@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: WARNING at local_bh_enable while tcp_retransmit
Date: Wed, 08 Dec 2010 21:20:31 +0100	[thread overview]
Message-ID: <4CFFE88F.3060200@gmail.com> (raw)
In-Reply-To: <20101208123645.84091844.isloginov@gmail.com>

Ilya Loginov wrote:
> On Tue, 07 Dec 2010 21:56:19 +0100
> Jarek Poplawski <jarkao2@gmail.com> wrote:
> 
>> Hi, isn't any of your drivers disabling irqs on this path?
> 
> No. But we are in soft_irq because tcp_retransmit. So, may be,
> interrupts were really disabled.

Should be easy to check by copying this WARN_ON_ONCE from 
kernel/softirq.c:143 local_bh_enable to the beginning of
your rioth_start_xmit.

Jarek P.

      reply	other threads:[~2010-12-08 20:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 15:23 WARNING at local_bh_enable while tcp_retransmit Ilya Loginov
2010-12-07 20:56 ` Jarek Poplawski
2010-12-08  9:36   ` Ilya Loginov
2010-12-08 20:20     ` Jarek Poplawski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CFFE88F.3060200@gmail.com \
    --to=jarkao2@gmail.com \
    --cc=davem@davemloft.net \
    --cc=isloginov@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).