From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH net-next-2.6 v8 20/20] CAN : Replace netif_rx to netif_receive_skb Date: Sun, 12 Dec 2010 16:15:09 +0100 Message-ID: <4D04E6FD.50106@pengutronix.de> References: <4CFE16A3.6070903@dsn.okisemi.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6766461552609986057==" Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Wolfgang Grandegger To: Tomoya MORINAGA Return-path: In-Reply-To: <4CFE16A3.6070903-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============6766461552609986057== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig04ADE4E05813609ACB2750FC" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig04ADE4E05813609ACB2750FC Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12/07/2010 12:12 PM, Tomoya MORINAGA wrote: > Since this driver is implemented as NAPI, > netif_receive_skb must be used not netif_rx. >=20 > Signed-off-by: Tomoya MORINAGA Looks good. Acked-by: Marc Kleine-Budde Marc > --- > drivers/net/can/pch_can.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c > index 4697b1c..8d45fdd 100644 > --- a/drivers/net/can/pch_can.c > +++ b/drivers/net/can/pch_can.c > @@ -572,7 +572,7 @@ static void pch_can_error(struct net_device *ndev, = u32 status) > cf->data[7] =3D (errc & PCH_REC) >> 8; > =20 > priv->can.state =3D state; > - netif_rx(skb); > + netif_receive_skb(skb); > =20 > stats->rx_packets++; > stats->rx_bytes +=3D cf->can_dlc; --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig04ADE4E05813609ACB2750FC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0E5wAACgkQjTAFq1RaXHO+/ACeOx5pkWUz7wuLSScnxBa7AGVA Z/QAn0Ho3vV9IPUoHqAakZ8Aml733ScJ =AlF3 -----END PGP SIGNATURE----- --------------enig04ADE4E05813609ACB2750FC-- --===============6766461552609986057== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Socketcan-core mailing list Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org https://lists.berlios.de/mailman/listinfo/socketcan-core --===============6766461552609986057==--