From: Tejun Heo <tj@kernel.org>
To: lkml <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Michael Chan <mchan@broadcom.com>,
netdev <netdev@vger.kernel.org>
Subject: [PATCH net-next-2.6] bnx2: remove cancel_work_sync() from remove_one
Date: Tue, 14 Dec 2010 17:09:59 +0100 [thread overview]
Message-ID: <4D0796D7.3030309@kernel.org> (raw)
Michael pointed out that bnx2_close() already cancels bp->reset_task
and thus it is guaranteed to be idle when bnx2_remove_one() is called.
Remove the unnecessary cancel_work_sync() in remove_one.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Michael Chan <mchan@broadcom.com>
---
drivers/net/bnx2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 5c811f3..85fc2c8 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -8393,8 +8393,6 @@ bnx2_remove_one(struct pci_dev *pdev)
struct net_device *dev = pci_get_drvdata(pdev);
struct bnx2 *bp = netdev_priv(dev);
- cancel_work_sync(&bp->reset_task);
-
unregister_netdev(dev);
if (bp->mips_firmware)
next reply other threads:[~2010-12-14 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 16:09 Tejun Heo [this message]
2010-12-14 17:48 ` [PATCH net-next-2.6] bnx2: remove cancel_work_sync() from remove_one Michael Chan
2010-12-15 13:52 ` Tejun Heo
2010-12-20 21:11 ` David Miller
2010-12-21 10:51 ` Tejun Heo
2010-12-21 20:20 ` David Miller
2010-12-22 8:48 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0796D7.3030309@kernel.org \
--to=tj@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).