From: Prasanna Panchamukhi <ppanchamukhi@riverbed.com>
To: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: [PATCH] net/e1000e : Fix to use dev_kfree_skb_any() instead of dev_kfree_skb() in _jumbo_rx_irq
Date: Fri, 17 Dec 2010 14:31:24 -0800 [thread overview]
Message-ID: <4D0BE4BC.10004@riverbed.com> (raw)
Several "Warning: kfree_skb on hard IRQ" messages have been observed from
the net/e1000e driver, e1000_clean_jumbo_rx_irq() routine calling
dev_kfree_skb(). This patch fixes the above warning messages by
calling dev_kfree_skb_any() instead of dev_kfree_skb().
Signed-off-by: Prasanna S. Panchamukhi<prasanna.panchamukhi@riverbed.com>
---
drivers/net/e1000e/netdev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index c4ca162..1068abc 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -1320,7 +1320,7 @@ static bool e1000_clean_jumbo_rx_irq(struct e1000_adapter *adapter,
/* an error means any chain goes out the window
* too */
if (rx_ring->rx_skb_top)
- dev_kfree_skb(rx_ring->rx_skb_top);
+ dev_kfree_skb_any(rx_ring->rx_skb_top);
rx_ring->rx_skb_top = NULL;
goto next_desc;
}
@@ -1393,7 +1393,7 @@ static bool e1000_clean_jumbo_rx_irq(struct e1000_adapter *adapter,
/* eth type trans needs skb->data to point to something */
if (!pskb_may_pull(skb, ETH_HLEN)) {
e_err("pskb_may_pull failed.\n");
- dev_kfree_skb(skb);
+ dev_kfree_skb_any(skb);
goto next_desc;
}
--
1.7.0.4
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next reply other threads:[~2010-12-17 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 22:31 Prasanna Panchamukhi [this message]
2010-12-18 3:17 ` [PATCH] net/e1000e : Fix to use dev_kfree_skb_any() instead of dev_kfree_skb() in _jumbo_rx_irq Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0BE4BC.10004@riverbed.com \
--to=ppanchamukhi@riverbed.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=prasanna.panchamukhi@riverbed.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox