From: Jarek Poplawski <jarkao2@gmail.com>
To: "Paweł Staszewski" <pstaszewski@itcare.pl>
Cc: Changli Gao <xiaosuo@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Linux Network Development list <netdev@vger.kernel.org>
Subject: Re: Kernel panic eth2 mirred redirect to ifb0
Date: Sun, 19 Dec 2010 23:26:23 +0100 [thread overview]
Message-ID: <4D0E868F.90005@gmail.com> (raw)
In-Reply-To: <4D0E857E.5060302@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
Jarek Poplawski wrote:
> Jarek Poplawski wrote:
>> Paweł Staszewski wrote:
>
>>> for sch_generic.h was ok.
>>
>> Should be enough to try after reverting this sch_generic.h change only.
>
> Hmm... Sorry, I meant the change inside skb_act_clone(). I'll send a patch.
Here it is.
Jarek P.
[-- Attachment #2: sch_generic.h.act_clone.1.diff --]
[-- Type: text/plain, Size: 644 bytes --]
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index ea1f8a8..8763ccc 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -608,13 +608,7 @@ static inline u32 qdisc_l2t(struct qdisc_rate_table* rtab, unsigned int pktlen)
static inline struct sk_buff *skb_act_clone(struct sk_buff *skb, gfp_t gfp_mask,
int action)
{
- struct sk_buff *n;
-
- if ((action == TC_ACT_STOLEN || action == TC_ACT_QUEUED) &&
- !skb_shared(skb))
- n = skb_get(skb);
- else
- n = skb_clone(skb, gfp_mask);
+ struct sk_buff *n = skb_clone(skb, gfp_mask);
if (n) {
n->tc_verd = SET_TC_VERD(n->tc_verd, 0);
next prev parent reply other threads:[~2010-12-19 22:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-19 11:35 Kernel panic eth2 mirred redirect to ifb0 Paweł Staszewski
2010-12-19 11:39 ` Paweł Staszewski
2010-12-19 15:43 ` Eric Dumazet
2010-12-19 16:09 ` Paweł Staszewski
2010-12-19 16:22 ` Changli Gao
2010-12-19 20:34 ` Paweł Staszewski
2010-12-19 22:15 ` Jarek Poplawski
2010-12-19 22:21 ` Jarek Poplawski
2010-12-19 22:26 ` Jarek Poplawski [this message]
2010-12-20 8:01 ` Paweł Staszewski
2010-12-20 8:06 ` Eric Dumazet
2010-12-20 9:13 ` Paweł Staszewski
2010-12-20 8:56 ` Changli Gao
2010-12-20 9:08 ` Eric Dumazet
2010-12-20 9:11 ` Changli Gao
2010-12-20 9:21 ` Eric Dumazet
2010-12-20 10:32 ` Jarek Poplawski
2010-12-20 10:41 ` Eric Dumazet
2010-12-20 11:11 ` Jarek Poplawski
2010-12-20 11:58 ` Jarek Poplawski
2010-12-20 12:07 ` Paweł Staszewski
2010-12-20 12:22 ` Jarek Poplawski
2010-12-20 12:45 ` Eric Dumazet
2010-12-20 12:54 ` Eric Dumazet
2010-12-20 13:02 ` Jarek Poplawski
2010-12-20 14:05 ` Changli Gao
2010-12-20 14:25 ` [PATCH net-next-2.6] ifb: add performance flags to dev->features Eric Dumazet
2010-12-20 14:43 ` Changli Gao
2010-12-28 21:50 ` David Miller
2010-12-28 22:36 ` Eric Dumazet
2010-12-28 23:07 ` Jarek Poplawski
2011-01-02 20:24 ` [PATCH v2 net-next-2.6] ifb: add performance flags Eric Dumazet
2011-01-03 19:37 ` Jarek Poplawski
2011-01-03 19:40 ` David Miller
2011-01-03 20:35 ` Eric Dumazet
2011-01-03 20:40 ` David Miller
2010-12-20 12:30 ` Kernel panic eth2 mirred redirect to ifb0 Changli Gao
2010-12-20 13:37 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0E868F.90005@gmail.com \
--to=jarkao2@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pstaszewski@itcare.pl \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).