From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Kurt Van Dijck <kurt.van.dijck@eia.be>
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6 1/2] can: add driver for Softing card
Date: Thu, 23 Dec 2010 21:33:05 +0100 [thread overview]
Message-ID: <4D13B201.1090906@hartkopp.net> (raw)
In-Reply-To: <4D135BC3.6070707@pengutronix.de>
Hello Kurt,
thanks for the effort to make this driver available in Mainline!
>> +
>> +MODULE_DESCRIPTION("socketcan softing driver");
MODULE_DESCRIPTION("Softing CAN driver");
MODULE_DESCRIPTION("Softing DPRAM CAN driver");
???
>> diff --git a/drivers/net/can/softing/softing_platform.h b/drivers/net/can/softing/softing_platform.h
>> new file mode 100644
>> index 0000000..9ff69a1
>> --- /dev/null
>> +++ b/drivers/net/can/softing/softing_platform.h
Shouldn't this file be placed in include/linux/can/platform/softing.h ??
Regards,
Oliver
next prev parent reply other threads:[~2010-12-23 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 9:36 [PATCH net-next-2.6 0/2] can: add driver for Softing card Kurt Van Dijck
[not found] ` <20101223093627.GA325-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2010-12-23 9:43 ` [PATCH net-next-2.6 1/2] " Kurt Van Dijck
[not found] ` <20101223094302.GB325-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2010-12-23 14:25 ` Marc Kleine-Budde
2010-12-23 20:33 ` Oliver Hartkopp [this message]
[not found] ` <4D135BC3.6070707-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-12-24 9:14 ` Kurt Van Dijck
[not found] ` <20101224091428.GA375-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2010-12-24 11:44 ` Marc Kleine-Budde
[not found] ` <4D148788.3010808-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-01-03 16:38 ` Kurt Van Dijck
[not found] ` <20110103163835.GD320-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-03 17:33 ` David Miller
[not found] ` <20110103.093327.104057155.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-01-04 10:54 ` Marc Kleine-Budde
2011-01-04 17:31 ` David Miller
2011-01-04 12:19 ` Kurt Van Dijck
2011-01-04 12:25 ` Marc Kleine-Budde
2011-01-03 16:28 ` Kurt Van Dijck
2010-12-23 9:47 ` [PATCH net-next-2.6 2/2] " Kurt Van Dijck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D13B201.1090906@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=kurt.van.dijck@eia.be \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).