From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Dan Rosenberg <drosenberg@vsecurity.com>
Cc: Urs Thuermann <urs.thuermann@volkswagen.de>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH v2] CAN: Use inode instead of kernel address for /proc file
Date: Mon, 27 Dec 2010 14:39:19 +0100 [thread overview]
Message-ID: <4D189707.5000708@hartkopp.net> (raw)
In-Reply-To: <1293382493.9764.54.camel@Dan>
On 26.12.2010 17:54, Dan Rosenberg wrote:
> Since the socket address is just being used as a unique identifier, its
> inode number is an alternative that does not leak potentially sensitive
> information.
>
> CC-ing stable because MITRE has assigned CVE-2010-4565 to the issue.
>
> Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
> Cc: stable <stable@kernel.org>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Thanks Dan
> ---
> net/can/bcm.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/can/bcm.c b/net/can/bcm.c
> index 6faa825..bc51b56 100644
> --- a/net/can/bcm.c
> +++ b/net/can/bcm.c
> @@ -125,7 +125,7 @@ struct bcm_sock {
> struct list_head tx_ops;
> unsigned long dropped_usr_msgs;
> struct proc_dir_entry *bcm_proc_read;
> - char procname [20]; /* pointer printed in ASCII with \0 */
> + char procname [32]; /* inode number in decimal with \0 */
> };
>
> static inline struct bcm_sock *bcm_sk(const struct sock *sk)
> @@ -1521,7 +1521,7 @@ static int bcm_connect(struct socket *sock, struct sockaddr *uaddr, int len,
>
> if (proc_dir) {
> /* unique socket address as filename */
> - sprintf(bo->procname, "%p", sock);
> + sprintf(bo->procname, "%lu", sock_i_ino(sk));
> bo->bcm_proc_read = proc_create_data(bo->procname, 0644,
> proc_dir,
> &bcm_proc_fops, sk);
>
>
next prev parent reply other threads:[~2010-12-27 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-26 16:54 [PATCH v2] CAN: Use inode instead of kernel address for /proc file Dan Rosenberg
2010-12-27 13:39 ` Oliver Hartkopp [this message]
2010-12-31 19:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D189707.5000708@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=urs.thuermann@volkswagen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).