From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: sch_sfb Date: Fri, 14 Jan 2011 02:39:21 +0100 Message-ID: <4D2FA949.8020701@trash.net> References: <1292855730-19265-1-git-send-email-xiaosuo@gmail.com> <20101220232020.GB2052@del.dom.local> <1292887689.2627.150.camel@edumazet-laptop> <20101220235209.GA1865@del.dom.local> <1292939574.6535.27.camel@mojatatu> <20101221223704.GA1979@del.dom.local> <1293111333.11306.170.camel@mojatatu> <1294003631.2535.253.camel@edumazet-laptop> <20110103095842.7677130d@nehalam> <4D2EE708.8010806@trash.net> <87bp3kg58i.fsf_-_@trurl.pps.jussieu.fr> <4D2F4B83.6060001@trash.net> <7ir5cgs3k1.fsf@lanthane.pps.jussieu.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netdev , Jesper Dangaard Brouer , David Miller To: Juliusz Chroboczek Return-path: Received: from stinky.trash.net ([213.144.137.162]:56042 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034Ab1ANBjT (ORCPT ); Thu, 13 Jan 2011 20:39:19 -0500 In-Reply-To: <7ir5cgs3k1.fsf@lanthane.pps.jussieu.fr> Sender: netdev-owner@vger.kernel.org List-ID: On 14.01.2011 01:59, Juliusz Chroboczek wrote: >> Since to my knowledge you've never attempted an upstream merge > > You're kidding, I hope. > > http://thread.gmane.org/gmane.linux.network/90225 > http://thread.gmane.org/gmane.linux.network/90375 > > It was reviewed in particular by one Patrick McHardy. Well, sorry, I don't remember every patch I've ever reviewed. Just to state it again, I've actually started implementing this years ago without every finishing it and was quite happy about noticing your implementation for inspiration. There's no reason to be pissed, I don't really mind which version is merged if any, reimplementing just forced me to think from scratch, with existing code at hand this makes it easier to avoid or fix mistakes.