From: Michael Tokarev <mjt@tls.msk.ru>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, "Jarek Kamiński" <jarek@vilo.eu.org>,
Hayes <hayeswang@realtek.com>, "Ben Hutchings" <benh@debian.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] r8169: keep firmware in memory.
Date: Fri, 14 Jan 2011 09:52:12 +0300 [thread overview]
Message-ID: <4D2FF29C.1050101@msgid.tls.msk.ru> (raw)
In-Reply-To: <20110113230753.GA2750@electric-eye.fr.zoreil.com>
14.01.2011 02:07, Francois Romieu wrote:
> The firmware agent is not available during resume. Loading the firmware
> during open() (see eee3a96c6368f47df8df5bd4ed1843600652b337) is not
> enough.
>
> close() is run during resume through rtl8169_reset_task(), whence the
> mildly natural release of firmware in the driver removal method instead.
>
> It will help with http://bugs.debian.org/609538. It will not avoid
> the 60 seconds delay when:
> - there is no firmware
> - the driver is loaded and the device is not up before a suspend/resume
Given all this I think this is somewhat clumsy still. How
does other NIC drivers handles this situation - e.g. tg3?
Maybe this needs to be a generic solution instead of per-driver?
/mjt
next prev parent reply other threads:[~2011-01-14 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 23:07 [PATCH] r8169: keep firmware in memory Francois Romieu
2011-01-14 5:50 ` David Miller
2011-01-14 6:52 ` Michael Tokarev [this message]
2011-01-14 16:05 ` Linus Torvalds
2011-01-14 16:30 ` Ben Hutchings
2011-01-14 17:21 ` Linus Torvalds
2011-01-14 21:44 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2FF29C.1050101@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=benh@debian.org \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=jarek@vilo.eu.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox