From: Patrick McHardy <kaber@trash.net>
To: Juliusz Chroboczek <Juliusz.Chroboczek@pps.jussieu.fr>
Cc: netdev <netdev@vger.kernel.org>, David Miller <davem@davemloft.net>
Subject: Re: sch_sfb
Date: Fri, 14 Jan 2011 14:37:44 +0100 [thread overview]
Message-ID: <4D3051A8.6050305@trash.net> (raw)
In-Reply-To: <7ivd1rsj6n.fsf@lanthane.pps.jussieu.fr>
On 14.01.2011 14:34, Juliusz Chroboczek wrote:
>> I just looked at it out of interest after already having started my
>> own version.
>
>>> http://thread.gmane.org/gmane.linux.network/90225
>>> http://thread.gmane.org/gmane.linux.network/90375
>
>>> It was reviewed in particular by one Patrick McHardy.
>
>> There's no reason to be pissed
>
> Yes, there is.
>
> First you object to my patch by making a bunch of unreasonable requests
> (notably that I use the in-kernel classifiers, which are not usable with
> Bloom filters).
They are - at least the flow classifier and others returning numerical
classids. Which is the one most useful for SFB.
> Then it turns out you're implementing your own version
> "from scratch". And then you claim that you never saw my version in the
> first place?
I said I didn't remember reviewing it. If you read my first email,
I specifically stated that I had a look at your version and noticed
a few bugs,
> Patrick, what you're doing is not merely rude, it's actually unethical.
I'm not continuing this discussion.
next prev parent reply other threads:[~2011-01-14 13:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 14:35 [PATCH net-2.6] net_sched: always clone skbs Changli Gao
2010-12-20 14:37 ` Eric Dumazet
2010-12-20 18:27 ` David Miller
2010-12-20 23:20 ` Jarek Poplawski
2010-12-20 23:28 ` Eric Dumazet
2010-12-20 23:52 ` Jarek Poplawski
2010-12-21 13:52 ` jamal
2010-12-21 14:17 ` Changli Gao
2010-12-21 22:37 ` Jarek Poplawski
2010-12-23 13:35 ` jamal
2010-12-23 23:04 ` Jarek Poplawski
2011-01-02 21:27 ` [RFC] net_sched: mark packet staying on queue too long Eric Dumazet
2011-01-03 13:52 ` jamal
2011-01-03 14:02 ` Eric Dumazet
2011-01-03 15:02 ` jamal
2011-01-03 18:11 ` [PATCH] sch_red: report backlog information Eric Dumazet
2011-01-03 20:13 ` David Miller
2011-01-03 17:58 ` [RFC] net_sched: mark packet staying on queue too long Stephen Hemminger
2011-01-04 14:19 ` Jesper Dangaard Brouer
2011-01-04 15:02 ` Eric Dumazet
2011-01-04 16:05 ` Stephen Hemminger
2011-01-04 18:20 ` Eric Dumazet
2011-01-04 18:29 ` Eric Dumazet
2011-01-13 11:50 ` Patrick McHardy
2011-01-13 15:54 ` Eric Dumazet
2011-01-13 16:04 ` sch_sfb [was: net_sched: mark packet staying on queue too long] Juliusz Chroboczek
2011-01-13 18:59 ` Patrick McHardy
2011-01-14 0:59 ` sch_sfb Juliusz Chroboczek
2011-01-14 1:39 ` sch_sfb Patrick McHardy
2011-01-14 13:34 ` sch_sfb Juliusz Chroboczek
2011-01-14 13:37 ` Patrick McHardy [this message]
2011-01-14 15:09 ` sch_sfb Eric Dumazet
2011-01-14 21:06 ` sch_sfb Jarek Poplawski
2010-12-21 0:21 ` [PATCH net-2.6] net_sched: always clone skbs Changli Gao
2010-12-21 3:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3051A8.6050305@trash.net \
--to=kaber@trash.net \
--cc=Juliusz.Chroboczek@pps.jussieu.fr \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).