From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shan Wei Subject: Re: [PATCH] sctp: user perfect name for Delayed SACK Timer option Date: Wed, 19 Jan 2011 16:17:07 +0800 Message-ID: <4D369E03.2000109@cn.fujitsu.com> References: <4D3693CA.40508@cn.fujitsu.com> <20110118.233932.91327830.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: vladislav.yasevich@hp.com, yjwei@cn.fujitsu.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org To: David Miller Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:50426 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753734Ab1ASIUg convert rfc822-to-8bit (ORCPT ); Wed, 19 Jan 2011 03:20:36 -0500 In-Reply-To: <20110118.233932.91327830.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: David Miller wrote, at 01/19/2011 03:39 PM: > From: Shan Wei > Date: Wed, 19 Jan 2011 15:33:30 +0800 >=20 >> The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK, >> not SCTP_DELAYED_ACK. >> >> Reference: >> 8.1.19. Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK) >> =EF=BC=88http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25) >> >> >> Signed-off-by: Shan Wei >=20 > You can't make this change, you'll break applications using the > existing definition. No documents guide user to use SCTP_DELAYED_ACK option. I double that there is no applications using this option. If, there be. How about keeping this be concomitant with SCTP_DELAYED_S= ACK? --=20 Best Regards ----- Shan Wei