From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: inbound connection problems when "netlink: test for all flags of the NLM_F_DUMP composite" commit applied Date: Wed, 19 Jan 2011 15:53:17 +0100 Message-ID: <4D36FADD.8000405@netfilter.org> References: <4D336050.9030602@netfilter.org> <20110118093811.GA7520@ff.dom.local> <20110118.020702.115924992.davem@davemloft.net> <20110118102437.GB7520@ff.dom.local> <4D35F8A3.1010600@netfilter.org> <20110118211450.GC4288@del.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: David Miller , arthur.marsh@internode.on.net, jengelh@medozas.de, eric.dumazet@gmail.com, netdev@vger.kernel.org, hadi@cyberus.ca To: Jarek Poplawski Return-path: Received: from mail.us.es ([193.147.175.20]:33655 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754470Ab1ASOx3 (ORCPT ); Wed, 19 Jan 2011 09:53:29 -0500 In-Reply-To: <20110118211450.GC4288@del.dom.local> Sender: netdev-owner@vger.kernel.org List-ID: On 18/01/11 22:14, Jarek Poplawski wrote: > On Tue, Jan 18, 2011 at 09:31:31PM +0100, Pablo Neira Ayuso wrote: >> On 18/01/11 11:24, Jarek Poplawski wrote: >>> On Tue, Jan 18, 2011 at 02:07:02AM -0800, David Miller wrote: >>>> From: Jarek Poplawski >>>> Date: Tue, 18 Jan 2011 09:38:11 +0000 >>>> >>>>> Even if I'm wrong, this change added to stable will break many configs. >>>>> My proposal is to revert commit 0ab03c2b147 until proper fix is found. >>>> >>>> The flag combination is, at best ambiguous, it has no proper >>>> definition without the check we added. >>> >>> Do you all expect all users manage to upgrade avahi app before >>> changing their stable kernel? I mean "own distro" users especially. >> >> The combination that avahi uses makes no sense. >> >> I've been auditing user-space tools that may have problems with this change: >> >> * iw (it uses libnl) >> * acpid (it uses a mangled version of libnetlink shipped in iproute) >> * tstime, for taskstats, it uses libnl >> * wimax-tools, it uses libnl >> * quota-tools, it uses libnl >> * keepalived, no libs used >> >> Well, I can keep looking for more, but I think that avahi is the only >> one doing this incorrectly. > > BTW, could you answer my earlier question, why NLM_F_ATOMIC flag isn't > handled now with dumps? The NLM_F_ATOMIC flag is not affected, the netlink header is still passed to netlink_dump_start() so you can check for it in the callback to start an atomic dump.