From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Miller <davem@davemloft.net>
Cc: jarkao2@gmail.com, arthur.marsh@internode.on.net,
jengelh@medozas.de, eric.dumazet@gmail.com,
netdev@vger.kernel.org, hadi@cyberus.ca
Subject: Re: inbound connection problems when "netlink: test for all flags of the NLM_F_DUMP composite" commit applied
Date: Wed, 19 Jan 2011 18:42:13 +0100 [thread overview]
Message-ID: <4D372275.3000104@netfilter.org> (raw)
In-Reply-To: <20110118.125051.260099262.davem@davemloft.net>
On 18/01/11 21:50, David Miller wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
> Date: Tue, 18 Jan 2011 21:31:31 +0100
>
>> The combination that avahi uses makes no sense.
>>
>> I've been auditing user-space tools that may have problems with this change:
>>
>> * iw (it uses libnl)
>> * acpid (it uses a mangled version of libnetlink shipped in iproute)
>> * tstime, for taskstats, it uses libnl
>> * wimax-tools, it uses libnl
>> * quota-tools, it uses libnl
>> * keepalived, no libs used
>>
>> Well, I can keep looking for more, but I think that avahi is the only
>> one doing this incorrectly.
>>
>> Please, fix avahi instead.
>
> That's a pretty compelling argument, so I'll hold off on the revert
> for now.
I've been reviewing user-space applications for a couple of hours (I've
got a big list here with no problems), unfortunately I found that:
ip route show cache
hangs after displaying the first line with the patch applied because it
uses:
req.nlh.nlmsg_type = RTM_GETROUTE;
req.nlh.nlmsg_flags = NLM_F_ROOT|NLM_F_REQUEST;
to dump the routing cache.
We need something less agressive, some warning to be printed and accept
this flag combination for quite some time until it's removed as jamal
and jarek suggested.
Please, revert this patch until we find a better solution.
next prev parent reply other threads:[~2011-01-19 17:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 8:54 inbound connection problems when "netlink: test for all flags of the NLM_F_DUMP composite" commit applied Arthur Marsh
2011-01-16 9:21 ` Eric Dumazet
2011-01-16 10:50 ` Jan Engelhardt
2011-01-16 12:39 ` Arthur Marsh
[not found] ` <4D32E3BA.5040008@internode.on.net>
2011-01-16 21:17 ` Pablo Neira Ayuso
2011-01-17 1:03 ` Arthur Marsh
2011-01-18 9:38 ` Jarek Poplawski
2011-01-18 10:07 ` David Miller
2011-01-18 10:24 ` Jarek Poplawski
2011-01-18 14:05 ` jamal
2011-01-18 14:07 ` jamal
2011-01-18 17:22 ` Jarek Poplawski
2011-01-18 18:11 ` Jarek Poplawski
2011-01-18 20:39 ` David Miller
2011-01-18 20:31 ` Pablo Neira Ayuso
2011-01-18 20:50 ` David Miller
2011-01-19 17:42 ` Pablo Neira Ayuso [this message]
2011-01-19 21:34 ` David Miller
2011-01-18 20:55 ` Jarek Poplawski
2011-01-19 14:28 ` jamal
2011-01-19 16:54 ` Jarek Poplawski
2011-01-19 16:59 ` jamal
2011-01-19 17:19 ` Jarek Poplawski
2011-01-19 17:33 ` Jarek Poplawski
2011-01-19 18:04 ` Jan Engelhardt
2011-01-19 19:24 ` Jarek Poplawski
2011-01-19 19:47 ` Jan Engelhardt
2011-01-19 20:12 ` Jarek Poplawski
2011-01-18 21:14 ` Jarek Poplawski
2011-01-19 14:53 ` Pablo Neira Ayuso
2011-01-19 16:18 ` Jarek Poplawski
-- strict thread matches above, loose matches on Subject: below --
2011-01-18 17:23 Jarek Poplawski
2011-01-18 18:10 ` Alessandro Suardi
2011-01-18 18:23 ` Jarek Poplawski
2011-01-18 18:24 ` Jan Engelhardt
2011-01-18 18:28 ` Jarek Poplawski
2011-01-18 18:47 ` Jarek Poplawski
2011-01-18 19:26 ` Alessandro Suardi
2011-01-18 20:07 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D372275.3000104@netfilter.org \
--to=pablo@netfilter.org \
--cc=arthur.marsh@internode.on.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=jarkao2@gmail.com \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).