From: Sakari Ailus <sakari.ailus@iki.fi>
To: Dan Carpenter <error27@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: tlan: Code cleanup: checkpatch.pl is relatively happy now.
Date: Sun, 06 Feb 2011 15:24:10 +0200 [thread overview]
Message-ID: <4D4EA0FA.6030603@iki.fi> (raw)
In-Reply-To: <20110206104330.GA4384@bicker>
Hi Dan,
Dan Carpenter wrote:
> Commit c659c38b279657 "tlan: Code cleanup: checkpatch.pl is relatively
> happy now." includes the following change without explanation.
>
> - if ( ( head_list->cStat& TLAN_CSTAT_READY ) == TLAN_CSTAT_READY ) {
> + if (head_list->c_stat& TLAN_CSTAT_READY) {
>
> Was this a bug fix or a bug introduce?
Ouch. Introduce in this case, unfortunately. I *thought*
TLAN_CSTAT_READY would have been a single bit instead of a bit mask. I
should have actually checked it, and still put that change into a
separate patch.
This might not be the one and only place where this kind of shortcut was
made --- for 80 characters per line compliance. There are very few,
anyway, in similar places.
I'll recheck the patch and provide a correction, in the coming days likely.
Many thanks for finding this!
--
Sakari Ailus
sakari.ailus@iki.fi
prev parent reply other threads:[~2011-02-06 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 10:43 tlan: Code cleanup: checkpatch.pl is relatively happy now Dan Carpenter
2011-02-06 13:24 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4EA0FA.6030603@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=error27@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).