* re: tlan: Code cleanup: checkpatch.pl is relatively happy now.
@ 2011-02-06 10:43 Dan Carpenter
2011-02-06 13:24 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-02-06 10:43 UTC (permalink / raw)
To: Sakari Ailus; +Cc: netdev
Commit c659c38b279657 "tlan: Code cleanup: checkpatch.pl is relatively
happy now." includes the following change without explanation.
- if ( ( head_list->cStat & TLAN_CSTAT_READY ) == TLAN_CSTAT_READY ) {
+ if (head_list->c_stat & TLAN_CSTAT_READY) {
Was this a bug fix or a bug introduce?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: tlan: Code cleanup: checkpatch.pl is relatively happy now.
2011-02-06 10:43 tlan: Code cleanup: checkpatch.pl is relatively happy now Dan Carpenter
@ 2011-02-06 13:24 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2011-02-06 13:24 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev
Hi Dan,
Dan Carpenter wrote:
> Commit c659c38b279657 "tlan: Code cleanup: checkpatch.pl is relatively
> happy now." includes the following change without explanation.
>
> - if ( ( head_list->cStat& TLAN_CSTAT_READY ) == TLAN_CSTAT_READY ) {
> + if (head_list->c_stat& TLAN_CSTAT_READY) {
>
> Was this a bug fix or a bug introduce?
Ouch. Introduce in this case, unfortunately. I *thought*
TLAN_CSTAT_READY would have been a single bit instead of a bit mask. I
should have actually checked it, and still put that change into a
separate patch.
This might not be the one and only place where this kind of shortcut was
made --- for 80 characters per line compliance. There are very few,
anyway, in similar places.
I'll recheck the patch and provide a correction, in the coming days likely.
Many thanks for finding this!
--
Sakari Ailus
sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-06 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-06 10:43 tlan: Code cleanup: checkpatch.pl is relatively happy now Dan Carpenter
2011-02-06 13:24 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).