From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jan Engelhardt <jengelh@medozas.de>, Avi Kivity <avi@redhat.com>,
netfilter-devel@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>,
nicolas prochazka <prochazka.nicolas@gmail.com>,
KVM list <kvm@vger.kernel.org>, netdev <netdev@vger.kernel.org>
Subject: Re: Possible netfilter-related memory corruption in 2.6.37
Date: Mon, 14 Feb 2011 17:52:13 +0100 [thread overview]
Message-ID: <4D595DBD.3090005@trash.net> (raw)
In-Reply-To: <1297702128.2996.41.camel@edumazet-laptop>
Am 14.02.2011 17:48, schrieb Eric Dumazet:
> Le lundi 14 février 2011 à 17:37 +0100, Patrick McHardy a écrit :
>> Am 14.02.2011 17:29, schrieb Eric Dumazet:
>>> Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit :
>>>>> Also, I wonder if RCU rules are respected in nf_iterate().
>>>>> For example this line is really suspicious :
>>>>>
>>>>> *i = (*i)->prev;
>>>>
>>>> Yeah, that definitely looks wrong. How about this instead?
>>>>
>>>
>>> This patch seems fine to me, thanks !
>>>
>>> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>>
>> THanks Eric, I've queued the patch for 2.6.38.
>
> I am not sure, but I guess nf_reinject() needs a fix too ;)
I agree. That one looks uglier though, I guess we'll have to
iterate through all hooks to note the previous one.
I'll take care of that once Dave has pulled the last fix
since I already sent out the pull request.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-14 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D594313.4050009@redhat.com>
2011-02-14 15:11 ` Possible netfilter-related memory corruption in 2.6.37 Eric Dumazet
2011-02-14 15:18 ` Jan Engelhardt
2011-02-14 15:50 ` Eric Dumazet
2011-02-14 16:24 ` Patrick McHardy
2011-02-14 16:29 ` Eric Dumazet
2011-02-14 16:37 ` Patrick McHardy
2011-02-14 16:48 ` Eric Dumazet
2011-02-14 16:52 ` Patrick McHardy [this message]
2011-02-18 18:37 ` Patrick McHardy
2011-02-18 19:14 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D595DBD.3090005@trash.net \
--to=kaber@trash.net \
--cc=avi@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jengelh@medozas.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=prochazka.nicolas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).