From: Henry Nestler <henry.nestler@gmail.com>
To: netdev@vger.kernel.org
Cc: trivial@kernel.org, akpm@linux-foundation.org, tori@unhappy.mine.nu
Subject: [PATCH 1/2] DM9000B: Fix reg_save after spin_lock in dm9000_timeout
Date: Sun, 20 Feb 2011 22:44:58 +0100 [thread overview]
Message-ID: <4D618B5A.4020009@henry.nestler.mail.gmail.com> (raw)
The spin_lock should hold before reading register.
---
Kernel version 2.6.38-rc5
drivers/net/dm9000.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index 2d4c4fc..2bbd496 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -852,8 +852,8 @@ static void dm9000_timeout(struct net_device *dev)
unsigned long flags;
/* Save previous register address */
- reg_save = readb(db->io_addr);
spin_lock_irqsave(&db->lock, flags);
+ reg_save = readb(db->io_addr);
netif_stop_queue(dev);
dm9000_reset(db);
reply other threads:[~2011-02-20 21:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D618B5A.4020009@henry.nestler.mail.gmail.com \
--to=henry.nestler@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=tori@unhappy.mine.nu \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox