From: "Jan Beulich" <JBeulich@novell.com>
To: "David Miller" <davem@davemloft.net>
Cc: <divy@chelsio.com>, <dm@chelsio.com>,
<linux-kbuild@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] cxgb{3,4}: streamline Kconfig options
Date: Wed, 23 Feb 2011 09:46:10 +0000 [thread overview]
Message-ID: <4D64E5720200007800033420@vpn.id2.novell.com> (raw)
In-Reply-To: <20110222.101457.39195901.davem@davemloft.net>
>>> On 22.02.11 at 19:14, David Miller <davem@davemloft.net> wrote:
> From: "Jan Beulich" <JBeulich@novell.com>
> Date: Thu, 17 Feb 2011 13:29:30 +0000
>
>> The CHELSIO_T{3,4}_DEPENDS options are really awkward, and can be
>> easily dropped if the reverse dependencies of SCSI_CXGB{3,4}_ISCSI on
>> the former get converted to normal (forward) ones referring to
>> CHELSIO_T{3,4}.
>>
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> I think the goal of these strange rules is not to be complicated
> on purpose, but rather to cause the iSCSI drivers to appear without
> the user having to know that he needs to enable the networking
> driver in order for that to happen.
While I realize that this might have been the reason, it's completely
contrary to how everyone else writes dependencies, and hence I
think these should be removed.
Jan
next prev parent reply other threads:[~2011-02-23 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 13:29 [PATCH] cxgb{3,4}: streamline Kconfig options Jan Beulich
2011-02-22 18:14 ` David Miller
2011-02-23 9:46 ` Jan Beulich [this message]
2011-02-23 20:27 ` David Miller
2011-02-24 8:00 ` Jan Beulich
2011-02-24 19:41 ` Dimitris Michailidis
2011-02-25 19:51 ` Dimitris Michailidis
2011-02-28 8:19 ` Jan Beulich
2011-02-28 21:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D64E5720200007800033420@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=dm@chelsio.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).