From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH net-next-2.6 1/2] dcbnl: add support for retrieving peer configuration - ieee Date: Thu, 24 Feb 2011 12:37:26 -0800 Message-ID: <4D66C186.7040409@intel.com> References: <1298581410.8877.21.camel@lb-tlvb-shmulik.il.broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "davem@davemloft.net" , Eilon Greenstein , "netdev@vger.kernel.org" To: Shmulik Ravid Return-path: Received: from mga02.intel.com ([134.134.136.20]:50007 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756508Ab1BXUh2 (ORCPT ); Thu, 24 Feb 2011 15:37:28 -0500 In-Reply-To: <1298581410.8877.21.camel@lb-tlvb-shmulik.il.broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2/24/2011 1:03 PM, Shmulik Ravid wrote: > These 2 patches add the support for retrieving the remote or peer DCBX > configuration via dcbnl for embedded DCBX stacks. The peer configuration > is part of the DCBX MIB and is useful for debugging and diagnostics of > the overall DCB configuration. The first patch add this support for IEEE > 802.1Qaz standard the second patch add the same support for the older > CEE standard. > > Signed-off-by: Shmulik Ravid > --- > include/linux/dcbnl.h | 38 ++++++++++++++++++++++++++ > include/net/dcbnl.h | 5 +++ > net/dcb/dcbnl.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 114 insertions(+), 0 deletions(-) > > diff --git a/include/linux/dcbnl.h b/include/linux/dcbnl.h > index 4c5b26e..3102185 100644 > --- a/include/linux/dcbnl.h > +++ b/include/linux/dcbnl.h > @@ -110,6 +110,22 @@ struct dcb_app { > __u16 protocol; > }; > > +/* This structure contains the APP feature information sent by the peer. > + * It is used for both the IEEE 802.1Qaz and the CEE flavors. > + * > + * @willing: willing bit in the peer APP tlv > + * @error: error bit in the peer APP tlv > + * @app_count: The number of objects in the peer APP table. > + * > + * In addition to this information the full peer APP tlv also contains > + * a table of 'app_count' APP objects defined above. > + */ > +struct dcb_peer_app_info { > + __u8 willing; > + __u8 error; > + __u16 app_count; > +}; > + The IEEE 802.1Qaz spec defines the APP TLV as informational so there are no willing or error bits in this case. See section D.2.12 of the 802.1Qaz draft. Can we drop these fields or do they have some other meaning here? Thanks, John.