* [PATCH] davinci: da850/omap-l138: Add Carrier Link OK check in Davinci RX Handler
@ 2011-02-25 9:56 Hegde, Vinay
2011-02-25 11:55 ` Sergei Shtylyov
2011-02-25 13:16 ` Cyril Chemparathy
0 siblings, 2 replies; 3+ messages in thread
From: Hegde, Vinay @ 2011-02-25 9:56 UTC (permalink / raw)
To: netdev; +Cc: khilman, davinci-linux-open-source, linux-arm-kernel,
Hegde, Vinay
This patch adds an additional check in the Davinci EMAC RX Handler,
which tests the __LINK_STATE_NOCARRIER flag along with the
__LINK_STATE_START flag as part EMAC shutting down procedure.
This avoids
WARNING: at drivers/net/davinci_emac.c:1040 emac_rx_handler+0xf8/0x120()
during rtcwake used to suspend the target for a specified duration.
Signed-off-by: Hegde, Vinay <vinay.hegde@ti.com>
---
drivers/net/davinci_emac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 2a628d1..7018bfe 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -1008,7 +1008,7 @@ static void emac_rx_handler(void *token, int len, int status)
int ret;
/* free and bail if we are shutting down */
- if (unlikely(!netif_running(ndev))) {
+ if (unlikely(!netif_running(ndev) || !netif_carrier_ok(ndev))) {
dev_kfree_skb_any(skb);
return;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] davinci: da850/omap-l138: Add Carrier Link OK check in Davinci RX Handler
2011-02-25 9:56 [PATCH] davinci: da850/omap-l138: Add Carrier Link OK check in Davinci RX Handler Hegde, Vinay
@ 2011-02-25 11:55 ` Sergei Shtylyov
2011-02-25 13:16 ` Cyril Chemparathy
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2011-02-25 11:55 UTC (permalink / raw)
To: Hegde, Vinay; +Cc: netdev, davinci-linux-open-source, linux-arm-kernel
Hello.
On 25-02-2011 12:56, Hegde, Vinay wrote:
This is not a patch to arch/arm/mach-davinci/, so the summary prefix
should not be "davinci: da850/omap-l138:" but rather "davinci_emac:" as you're
patching this driver.
> This patch adds an additional check in the Davinci EMAC RX Handler,
> which tests the __LINK_STATE_NOCARRIER flag along with the
> __LINK_STATE_START flag as part EMAC shutting down procedure.
> This avoids
> WARNING: at drivers/net/davinci_emac.c:1040 emac_rx_handler+0xf8/0x120()
> during rtcwake used to suspend the target for a specified duration.
> Signed-off-by: Hegde, Vinay <vinay.hegde@ti.com>
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 2a628d1..7018bfe 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1008,7 +1008,7 @@ static void emac_rx_handler(void *token, int len, int status)
> int ret;
>
> /* free and bail if we are shutting down */
> - if (unlikely(!netif_running(ndev))) {
> + if (unlikely(!netif_running(ndev) || !netif_carrier_ok(ndev))) {
> dev_kfree_skb_any(skb);
> return;
> }
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] davinci: da850/omap-l138: Add Carrier Link OK check in Davinci RX Handler
2011-02-25 9:56 [PATCH] davinci: da850/omap-l138: Add Carrier Link OK check in Davinci RX Handler Hegde, Vinay
2011-02-25 11:55 ` Sergei Shtylyov
@ 2011-02-25 13:16 ` Cyril Chemparathy
1 sibling, 0 replies; 3+ messages in thread
From: Cyril Chemparathy @ 2011-02-25 13:16 UTC (permalink / raw)
To: Hegde, Vinay
Cc: netdev@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
linux-arm-kernel@lists.infradead.org
On 02/25/2011 04:56 AM, Hegde, Vinay wrote:
> This patch adds an additional check in the Davinci EMAC RX Handler,
> which tests the __LINK_STATE_NOCARRIER flag along with the
> __LINK_STATE_START flag as part EMAC shutting down procedure.
>
> This avoids
> WARNING: at drivers/net/davinci_emac.c:1040 emac_rx_handler+0xf8/0x120()
> during rtcwake used to suspend the target for a specified duration.
>
> Signed-off-by: Hegde, Vinay <vinay.hegde@ti.com>
> ---
> drivers/net/davinci_emac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 2a628d1..7018bfe 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1008,7 +1008,7 @@ static void emac_rx_handler(void *token, int len, int status)
> int ret;
>
> /* free and bail if we are shutting down */
> - if (unlikely(!netif_running(ndev))) {
> + if (unlikely(!netif_running(ndev) || !netif_carrier_ok(ndev))) {
> dev_kfree_skb_any(skb);
> return;
> }
Looks ok.
Acked-by: Cyril Chemparathy <cyril@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-25 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-25 9:56 [PATCH] davinci: da850/omap-l138: Add Carrier Link OK check in Davinci RX Handler Hegde, Vinay
2011-02-25 11:55 ` Sergei Shtylyov
2011-02-25 13:16 ` Cyril Chemparathy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).