From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladislav Yasevich Subject: Re: [PATCH] sctp: do not mark chunk abandoned if peer has no PRSCTP capable Date: Thu, 03 Mar 2011 09:14:50 -0500 Message-ID: <4D6FA25A.6030401@hp.com> References: <4D6F1723.5030909@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , lksctp , David Miller To: Wei Yongjun Return-path: Received: from g1t0028.austin.hp.com ([15.216.28.35]:36891 "EHLO g1t0028.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909Ab1CCOO4 (ORCPT ); Thu, 3 Mar 2011 09:14:56 -0500 In-Reply-To: <4D6F1723.5030909@cn.fujitsu.com> Sender: netdev-owner@vger.kernel.org List-ID: On 03/02/2011 11:20 PM, Wei Yongjun wrote: > Chunk is marked abandoned if the chunk is expires, and it not be > retransmited even if the peer has no PRSCTP capable, but the peer > will still wait for retransmit it to update CTSN. > This patch disable mark chunk abandoned if peer has no PRSCTP > capable. > > Signed-off-by: Wei Yongjun > --- > net/sctp/chunk.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/net/sctp/chunk.c b/net/sctp/chunk.c > index 6c85564..0d4832d 100644 > --- a/net/sctp/chunk.c > +++ b/net/sctp/chunk.c > @@ -347,6 +347,9 @@ int sctp_chunk_abandoned(struct sctp_chunk *chunk) > { > struct sctp_datamsg *msg = chunk->msg; > > + if (!chunk->asoc->peer.prsctp_capable) > + return 0; > + > if (!msg->can_abandon) > return 0; > The trouble is that timetolive can be set on a message independent of Partial Reliability. The difference in behavior is that when PR can't be used, a chunk can only be abandoned if it has not yet been transmitted. With PR enabled, the chunk can be abandoned at any time. So, you can't blindly disallow abandonment. -vlad