From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Xiaotian Feng <dfeng@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
Tom Herbert <therbert@google.com>, Jiri Pirko <jpirko@redhat.com>
Subject: Re: [RFC PATCH] net/core: fix skb handling on netif serves for both bridge and vlan
Date: Thu, 03 Mar 2011 22:42:24 +0100 [thread overview]
Message-ID: <4D700B40.9010209@gmail.com> (raw)
In-Reply-To: <1299160414.4277.49.camel@localhost>
Le 03/03/2011 14:53, Ben Hutchings a écrit :
> On Thu, 2011-03-03 at 18:55 +0800, Xiaotian Feng wrote:
>> Consider network topology as follows:
>>
>> eth0 eth1
>> |_____|
>> |
>> bond0 --- br0
>> |
>> vlan0 --- br1
>>
>> bond0 serves for both br0 and vlan0, if a vlan tagged packet was sent
>> to br1 through bond0, bridge handling code is seeing the packet on bond0
>> and handing it off to my "legacy" bridge before vlan_tx_tag_present
>> and vlan_hwaccel_do_receive even haven't a chance to look at it.
> [...]
>
> This used to work if the underlying device (bond0 in your example)
> implemented VLAN tag extraction, because the VLAN group would be checked
> before the bridge. But it never worked for devices without VLAN tag
> extraction. Perhaps we should just prevent this configuration.
If Jiri Pirko eventually move vlan processing to rx_handler, then the setup won't be possible,
because bond0 would require two rx_handlers : one for bridge (-> br0) and one for vlan (-> vlan0).
Or we need several rx_handlers per net_device, if the above setup is a real one.
Nicolas.
next prev parent reply other threads:[~2011-03-03 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 10:55 [RFC PATCH] net/core: fix skb handling on netif serves for both bridge and vlan Xiaotian Feng
2011-03-03 13:53 ` Ben Hutchings
2011-03-03 21:42 ` Nicolas de Pesloüan [this message]
2011-03-05 10:36 ` Jiri Pirko
2011-03-05 13:53 ` Nicolas de Pesloüan
2011-03-05 14:25 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D700B40.9010209@gmail.com \
--to=nicolas.2p.debian@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dfeng@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).