netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Turull <daniel.turull@gmail.com>
To: netdev@vger.kernel.org
Cc: 이종원 <ljw@handong.edu>, "Robert Olsson" <robert@herjulf.net>
Subject: [PATCH] pktgen: fix errata in show results
Date: Mon, 07 Mar 2011 10:09:43 +0100	[thread overview]
Message-ID: <4D74A0D7.3020506@gmail.com> (raw)

The units in show_results in pktgen were not correct.
The results are in usec but it was displayed nsec.

Reported-by: Jong-won Lee <ljw@handong.edu>
Signed-off-by: Daniel Turull <daniel.turull@gmail.com>
---
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index d73b77a..f0aec6c 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3271,7 +3271,7 @@ static void show_results(struct pktgen_dev 
*pkt_dev, int nr_frags)
                      pkt_dev->started_at);
      ktime_t idle = ns_to_ktime(pkt_dev->idle_acc);

-    p += sprintf(p, "OK: %llu(c%llu+d%llu) nsec, %llu (%dbyte,%dfrags)\n",
+    p += sprintf(p, "OK: %llu(c%llu+d%llu) usec, %llu (%dbyte,%dfrags)\n",
               (unsigned long long)ktime_to_us(elapsed),
               (unsigned long long)ktime_to_us(ktime_sub(elapsed, idle)),
               (unsigned long long)ktime_to_us(idle),

             reply	other threads:[~2011-03-07  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07  9:09 Daniel Turull [this message]
2011-03-07  9:19 ` [PATCH] pktgen: fix errata in show results David Miller
2011-03-07  9:44   ` Daniel Turull
2011-03-09 22:11     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D74A0D7.3020506@gmail.com \
    --to=daniel.turull@gmail.com \
    --cc=ljw@handong.edu \
    --cc=netdev@vger.kernel.org \
    --cc=robert@herjulf.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).