From: Piotr Hosowicz <piotr@hosowicz.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Anca Emanuel <anca.emanuel@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Francois Romieu <romieu@fr.zoreil.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] r8169: fix a bug in rtl8169_init_phy()
Date: Sat, 19 Mar 2011 16:52:03 +0100 [thread overview]
Message-ID: <4D84D123.8060903@example.com> (raw)
In-Reply-To: <201103191641.41718.oliver@neukum.org>
On 19.03.2011 16:41, Oliver Neukum wrote:
> Am Samstag, 19. März 2011, 16:39:11 schrieben Sie:
>> Le samedi 19 mars 2011 à 16:33 +0100, Eric Dumazet a écrit :
>>> Le samedi 19 mars 2011 à 16:31 +0100, Oliver Neukum a écrit :
>>>> Am Samstag, 19. März 2011, 16:18:50 schrieb Eric Dumazet:
>>>>
>>>>> Problem comes from commit 54405cde762408b00a445466a40da4f7f33a8479
>>>>> (r8169: support control of advertising.)
>>>>>
>>>>> Reverting it brings back NIC for me
>>>>
>>>> Odd. It worked for me. Are you testing on a gigabit switch? Could you send
>>>> me dmesg? Does it work if you use ethtool to advertise a lower speed?
>>>>
>>>> Regards
>>>> Oliver
>>>
>>> I found the bug, I am sending a patch in two minutes.
>>>
>>
>> Here it is
>>
>> [PATCH] r8169: fix a bug in rtl8169_init_phy()
>>
>> commit 54405cde7624 (r8169: support control of advertising.)
>> introduced a bug in rtl8169_init_phy()
>
> Thank you. I feel like banging my head against something.
If it will work I will be banging against the wall. I am missing for a
fresh new kernel with networking.
--
Szef TVN24 do dziennikarzy: Kochani, przez dwa lata waliliśmy w obóz
rządzący. Tak dalej byc nie może. Jesteśmy telewizją niezależną i to
zobowiązuje. Teraz będziemy kopać w opozycję.
NP: Big Big Train - Victorian Brickwork
NB: 2.6.38-git3
next prev parent reply other threads:[~2011-03-19 15:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D84A46B.1000407@example.com>
[not found] ` <AANLkTi=qrK2L+MA5F5fQ6S76LLPXkYhyLg7JL4_vrkRe@mail.gmail.com>
[not found] ` <4D84A9F6.8080402@example.com>
2011-03-19 14:08 ` No networking since git3 Anca Emanuel
2011-03-19 15:18 ` Eric Dumazet
2011-03-19 15:31 ` Oliver Neukum
2011-03-19 15:33 ` Eric Dumazet
2011-03-19 15:39 ` [PATCH] r8169: fix a bug in rtl8169_init_phy() Eric Dumazet
2011-03-19 15:41 ` Oliver Neukum
2011-03-19 15:44 ` Eric Dumazet
2011-03-19 15:52 ` Piotr Hosowicz [this message]
2011-03-19 19:41 ` Francois Romieu
2011-03-19 15:49 ` Piotr Hosowicz
2011-03-19 16:04 ` Eric Dumazet
2011-03-19 16:27 ` Piotr Hosowicz
2011-03-19 16:38 ` Anca Emanuel
2011-03-19 16:41 ` Eric Dumazet
2011-03-19 17:03 ` Piotr Hosowicz
2011-03-19 16:03 ` Piotr Hosowicz
2011-03-19 17:20 ` Anca Emanuel
2011-03-19 18:59 ` Piotr Hosowicz
2011-03-19 20:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D84D123.8060903@example.com \
--to=piotr@hosowicz.com \
--cc=anca.emanuel@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).