From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: Jiri Pirko <jpirko@redhat.com>,
netdev@vger.kernel.org, davem@davemloft.net, fubar@us.ibm.com
Subject: Re: [patch net-2.6] bonding: fix rx_handler locking
Date: Tue, 22 Mar 2011 21:35:37 +0100 [thread overview]
Message-ID: <4D890819.5020202@gmail.com> (raw)
In-Reply-To: <20110322202634.GA11864@gospo.rdu.redhat.com>
Le 22/03/2011 21:26, Andy Gospodarek a écrit :
> On Tue, Mar 22, 2011 at 01:38:12PM +0100, Jiri Pirko wrote:
>> This prevents possible race between bond_enslave and bond_handle_frame
>> as reported by Nicolas by moving rx_handler register/unregister.
>> slave->bond is added to hold pointer to master bonding sructure. That
>> way dev->master is no longer used in bond_handler_frame.
>> Also, this removes "BUG: scheduling while atomic" message
>>
>> Reported-by: Nicolas de Pesloüan<nicolas.2p.debian@gmail.com>
>> Signed-off-by: Jiri Pirko<jpirko@redhat.com>
>
> Signed-off-by: Andy Gospodarek<andy@greyhouse.net>
>
> This seems reasonable. I presume Nicolas was able to test it and verify
> it resolved his issue?
Unfortunately, not yet. I plan to give it a try tonight... or tomorrow on the worst case.
Nicolas.
next prev parent reply other threads:[~2011-03-22 20:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 12:38 [patch net-2.6] bonding: fix rx_handler locking Jiri Pirko
2011-03-22 20:26 ` Andy Gospodarek
2011-03-22 20:35 ` Nicolas de Pesloüan [this message]
2011-03-23 2:07 ` Weiping Pan
2011-03-23 2:16 ` David Miller
2011-03-23 19:25 ` Nicolas de Pesloüan
2011-03-23 19:45 ` David Miller
2011-03-23 21:16 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D890819.5020202@gmail.com \
--to=nicolas.2p.debian@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).