From: Andrew Gallatin <gallatin@myri.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: netdev@vger.kernel.org, Brice Goglin <brice@myri.com>,
Stephen Hemminger <shemminger@vyatta.com>,
David Howells <dhowells@redhat.com>,
Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH] myri10ge: small rx_done refactoring
Date: Fri, 25 Mar 2011 09:03:53 -0400 [thread overview]
Message-ID: <4D8C92B9.1010109@myri.com> (raw)
In-Reply-To: <20110325112123.GA6218@redhat.com>
On 03/25/11 07:21, Stanislaw Gruszka wrote:
> Avoid theoretical race condition regarding accessing dev->features
> NETIF_F_LRO flag, which is illustrated below.
>
> CPU1 CPU2
>
> myri10ge_clean_rx_done(): myri10ge_set_flags():
> or
> myri10ge_set_rx_csum():
>
> if (dev->features& NETIF_F_LRO)
> setup lro
> dev->features |= NETIF_F_LRO
> or
> dev->features&= ~NETIF_F_LRO;
> if (dev->features& NETIF_F_LRO)
> flush lro
>
> On the way reduce myri10ge_rx_done() number of arguments and calls by
> moving mgp->small_bytes check into that function. That reduce code size
>
> from:
> text data bss dec hex filename
> 36644 248 100 36992 9080 drivers/net/myri10ge/myri10ge.o
>
> to:
> text data bss dec hex filename
> 36037 247 100 36384 8e20 drivers/net/myri10ge/myri10ge.o
>
> on my i686 system, what should also make myri10ge_clean_rx_done()
> being faster.
>
> Signed-off-by: Stanislaw Gruszka<sgruszka@redhat.com>
Thank you very much!
Acked by: Andrew Gallatin <gallatin@myri.com>
next prev parent reply other threads:[~2011-03-25 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 11:21 [PATCH] myri10ge: small rx_done refactoring Stanislaw Gruszka
2011-03-25 13:03 ` Andrew Gallatin [this message]
2011-03-28 1:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8C92B9.1010109@myri.com \
--to=gallatin@myri.com \
--cc=bhutchings@solarflare.com \
--cc=brice@myri.com \
--cc=dhowells@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).