From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH net-next-2.6 v2] can: convert protocol handling to RCU
Date: Wed, 06 Apr 2011 16:39:03 +0200
Message-ID: <4D9C7B07.20903@hartkopp.net>
References: <4D9B58EC.9090903@hartkopp.net> <20110406092727.GC342@kurt.e-circ.dyndns.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Urs Thuermann <urs@isnogud.escape.de>
To: Kurt Van Dijck <kurt.van.dijck@eia.be>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mo-p00-ob.rzone.de ([81.169.146.162]:19762 "EHLO
	mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756054Ab1DFOjP (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 6 Apr 2011 10:39:15 -0400
In-Reply-To: <20110406092727.GC342@kurt.e-circ.dyndns.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 06.04.2011 11:27, Kurt Van Dijck wrote:
> On Tue, Apr 05, 2011 at 08:01:16PM +0200, Oliver Hartkopp wrote:

>>  
>> +static struct can_proto *can_try_module_get(int protocol)
>> +{
>> +	struct can_proto *cp;
>> +
>> +	rcu_read_lock();
>> +	cp = rcu_dereference(proto_tab[protocol]);
>> +	if (cp && !try_module_get(cp->prot->owner))
> After the xxx_get, is the 'cp' pointer persistent?

try_module_get() increases the usage counter of the module - therefore it is.
It is protected until module_put(cp->prot->owner) at the end of can_create() .

>>  	/* check for available protocol and correct usage */
>>  
>>  	if (!cp)
>>  		return -EPROTONOSUPPORT;
>>  
>>  	if (cp->type != sock->type) {
> I don't see how this will evaluate to true?
> can_proto_register takes care of it.

This check compares the type of the socket that is to be created with the type
that's defined for this protocol.

E.g. if you would give

s = socket(PF_CAN, SOCK_STREAM, CAN_RAW);

instead of the correct

s = socket(PF_CAN, SOCK_RAW, CAN_RAW);

you will get this error.

>> -		err = -EPROTONOSUPPORT;
>> +		err = -EPROTOTYPE;
>>  		goto errout;
>>  	}
>>  

Regards,
Oliver