From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scot Doyle Subject: Re: [PATCH] bridge: reset IPCB in br_parse_ip_options Date: Wed, 13 Apr 2011 10:54:38 -0500 Message-ID: <4DA5C73E.8070700@scotdoyle.com> References: <4DA3F909.5020609@scotdoyle.com> <1302608951.3233.33.camel@edumazet-laptop> <1302613353.30934.22.camel@polaris.local> <1302614145.3233.47.camel@edumazet-laptop> <1302617968.30934.34.camel@polaris.local> <1302619749.3233.56.camel@edumazet-laptop> <1302621233.30934.44.camel@polaris.local> <1302624851.3233.63.camel@edumazet-laptop> <20110412092039.69f420f6@nehalam> <1302626152.3233.66.camel@edumazet-laptop> <20110412164557.GF2047@stratus.com> <1302627281.3233.70.camel@edumazet-laptop> <1302628720.3233.84.camel@edumazet-laptop> <4DA4E68B.9010401@scotdoyle.com> <4DA522B2.90200@scotdoyle.com> <4DA5BCF7.9020606@scotdoyle.com> <20110413082457.52784d6d@nehalam> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from smtp.scotdoyle.com ([74.207.249.244]:55196 "EHLO smtp.scotdoyle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757250Ab1DMPyk (ORCPT ); Wed, 13 Apr 2011 11:54:40 -0400 In-Reply-To: <20110413082457.52784d6d@nehalam> Sender: netdev-owner@vger.kernel.org List-ID: On 04/13/2011 10:24 AM, Stephen Hemminger wrote: >> The net effect is that three patches are required to eliminate the panics. >> >> These two patches have been accepted by David: >> http://article.gmane.org/gmane.linux.network/192015 >> http://article.gmane.org/gmane.linux.network/192055 >> >> This patch, incrementally authored by Stephen and Eric and compiled by >> me, is also required: >> http://article.gmane.org/gmane.linux.network/192007 >> >> What should happen for this third patch to be included upstream? > Although making IP more robust is a good. > I still think bridging shouldn't give bad packets to IP. I'm definitely willing to test alternative patches. The output without that third patch is: [ 761.720393] BUG: unable to handle kernel NULL pointer dereference at 00000000000000d0 [ 761.728206] IP: [] ip_options_compile+0x1c1/0x435 [ 761.734452] PGD 0 [ 761.736459] Oops: 0000 [#1] SMP [ 761.739683] last sysfs file: /sys/devices/virtual/misc/kvm/uevent [ 761.745744] CPU 0 [ 761.747570] Modules linked in: kvm_intel kvm bridge stp loop snd_pcm snd_timer snd tpm_tis tpm tpm_bios soundcore psmouse snd_page_alloc processor ghes thermal_sys i7core_edac evdev pcspkr serio_raw edac_core dcdbas power_meter button hed ext2 mbcache dm_mod raid1 md_mod sd_mod crc_t10dif usb_storage uas uhci_hcd ehci_hcd mpt2sas scsi_transport_sas raid_class igb scsi_mod usbcore bnx2 dca [last unloaded: scsi_wait_scan] [ 761.785171] [ 761.786651] Pid: 0, comm: swapper Not tainted 2.6.39-rc3+ #14 Dell Inc. PowerEdge R510/0DPRKF [ 761.795157] RIP: 0010:[] [] ip_options_compile+0x1c1/0x435 [ 761.803823] RSP: 0018:ffff88042f203af0 EFLAGS: 00010286 [ 761.809106] RAX: 0000000000000017 RBX: ffff8804027b3600 RCX: ffff88040466a864 [ 761.816205] RDX: 000000000000001a RSI: 0000000000000000 RDI: ffffffff817e6100 [ 761.823304] RBP: ffff88040466a862 R08: ffffffffa01d6e89 R09: ffff88042f203c58 [ 761.830402] R10: 0000000000000000 R11: 0000000000000000 R12: ffff8804027b3628 [ 761.837501] R13: 000000000000001d R14: ffff88040466a84e R15: 0000000000000024 [ 761.844601] FS: 0000000000000000(0000) GS:ffff88042f200000(0000) knlGS:0000000000000000 [ 761.852650] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 761.858365] CR2: 00000000000000d0 CR3: 0000000001603000 CR4: 00000000000006f0 [ 761.865463] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 761.872562] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 761.879661] Process swapper (pid: 0, threadinfo ffffffff81600000, task ffffffff8160b020) [ 761.887710] Stack: [ 761.889708] 0000000000000000 ffffffff81276928 0000000000000000 ffffffff817e6100 [ 761.897102] 000000000000004e ffff88040500e600 ffff88040500e600 ffff8804027b3600 [ 761.904496] ffff880404fc0000 ffff8804027b3628 0000000000000000 ffff880404fc0000 [ 761.911889] Call Trace: [ 761.914319] [ 761.916413] [] ? netif_receive_skb+0x52/0x58 [ 761.922306] [] ? br_parse_ip_options+0x134/0x1a8 [bridge] [ 761.929319] [] ? br_nf_pre_routing+0x348/0x3cb [bridge] [ 761.936160] [] ? nf_iterate+0x41/0x7e [ 761.941444] [] ? irq_exit+0x58/0x8f [ 761.946556] [] ? NF_HOOK.clone.4+0x56/0x56 [bridge] [ 761.953052] [] ? NF_HOOK.clone.4+0x56/0x56 [bridge] [ 761.959546] [] ? nf_hook_slow+0x73/0x114 [ 761.965089] [] ? NF_HOOK.clone.4+0x56/0x56 [bridge] [ 761.971583] [] ? __netdev_alloc_skb+0x15/0x2f [ 761.977561] [] ? NF_HOOK.clone.4+0x56/0x56 [bridge] [ 761.984055] [] ? NF_HOOK.clone.4+0x3c/0x56 [bridge] [ 761.990551] [] ? tcp_gro_receive+0xa1/0x204 [ 761.996355] [] ? br_handle_frame+0x195/0x1ac [bridge] [ 762.003022] [] ? br_handle_frame_finish+0x1c7/0x1c7 [bridge] [ 762.010294] [] ? __netif_receive_skb+0x2a7/0x450 [ 762.016530] [] ? netif_receive_skb+0x52/0x58 [ 762.022420] [] ? napi_gro_receive+0x1f/0x2f [ 762.028222] [] ? napi_skb_finish+0x1c/0x31 [ 762.033941] [] ? igb_poll+0x6d9/0x9ee [igb] [ 762.039744] [] ? handle_irq_event+0x40/0x55 [ 762.045547] [] ? arch_local_irq_save+0x14/0x1d [ 762.051609] [] ? net_rx_action+0xa4/0x1b1 [ 762.057239] [] ? __do_softirq+0xb8/0x176 [ 762.062783] [] ? call_softirq+0x1c/0x30 [ 762.068241] [] ? do_softirq+0x3f/0x84 [ 762.073524] [] ? irq_exit+0x3f/0x8f [ 762.078635] [] ? do_IRQ+0x85/0x9e [ 762.083575] [] ? common_interrupt+0x13/0x13 [ 762.089375] [ 762.091469] [] ? enqueue_hrtimer+0x3f/0x53 [ 762.097188] [] ? arch_local_irq_enable+0x7/0x8 [processor] [ 762.104288] [] ? acpi_idle_enter_c1+0x86/0xa2 [processor] [ 762.111303] [] ? cpuidle_idle_call+0xf4/0x17e [ 762.117277] [] ? cpu_idle+0xa2/0xc4 [ 762.122388] [] ? start_kernel+0x3b9/0x3c4 [ 762.128018] [] ? x86_64_start_kernel+0x102/0x10f [ 762.134253] Code: 4d 02 3c 03 0f 86 59 02 00 00 0f b6 d0 44 39 ea 7f 32 83 c2 03 44 39 ea 0f 8f 45 02 00 00 48 85 db 74 18 48 8b 74 24 10 0f b6 c0 <8b> 96 d0 00 00 00 89 54 05 ff 41 80 4c 24 08 04 80 01 04 41 80 [ 762.153593] RIP [] ip_options_compile+0x1c1/0x435 [ 762.159923] RSP [ 762.163391] CR2: 00000000000000d0 [ 762.167017] ---[ end trace e15d7b082f680b62 ]---