From: Dimitris Michailidis <dm@chelsio.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, Casey Leedom <leedom@chelsio.com>
Subject: Re: [PATCH v2] net: cxgb4{,vf}: convert to hw_features
Date: Sat, 16 Apr 2011 11:23:59 -0700 [thread overview]
Message-ID: <4DA9DEBF.8050300@chelsio.com> (raw)
In-Reply-To: <20110416165226.B881F13A65@rere.qmqm.pl>
Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> v2: cxgb4: remove now unneeded variable in t4_ethrx_handler()
> cxgb4vf: fix hw/vlan_features values
Thanks for doing this. The cxgb4 part looks good. For cxgb4vf I have a
comment below.
> @@ -2638,19 +2597,18 @@ static int __devinit cxgb4vf_pci_probe(struct pci_dev *pdev,
> - netdev->features = (NETIF_F_SG | TSO_FLAGS |
> - NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
> - NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
> - NETIF_F_GRO);
> + netdev->hw_features = NETIF_F_SG | TSO_FLAGS | NETIF_F_RXCSUM |
> + NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
> + netdev->vlan_features = NETIF_F_SG | TSO_FLAGS |
> + NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
> + NETIF_F_HW_VLAN_TX | NETIF_F_HIGHDMA;
This NETIF_F_HW_VLAN_TX looks misplaced. Did you mean to add it to
hw_features rather than vlan_features?
next prev parent reply other threads:[~2011-04-16 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 14:50 [PATCH] net: cxgb4{,vf}: convert to hw_features Michał Mirosław
2011-04-15 19:00 ` Dimitris Michailidis
2011-04-16 16:56 ` Michał Mirosław
2011-04-16 16:52 ` [PATCH v2] " Michał Mirosław
2011-04-16 18:23 ` Dimitris Michailidis [this message]
2011-04-16 23:04 ` Michał Mirosław
2011-04-16 23:05 ` [PATCH v3] " Michał Mirosław
2011-04-17 0:55 ` Dimitris Michailidis
2011-04-18 0:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA9DEBF.8050300@chelsio.com \
--to=dm@chelsio.com \
--cc=leedom@chelsio.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).