netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ipv6: Remove hoplimit initialization to -1
@ 2011-04-21  8:56 Thomas Egerer
  2011-04-22  0:25 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Egerer @ 2011-04-21  8:56 UTC (permalink / raw)
  To: davem; +Cc: netdev

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]


The changes introduced with git-commit a02e4b7d missed to remove the
hoplimit initialization. As a result, ipv6_get_mtu interprets the return
value of dst_metric_raw (-1) as 255 and answers ping6 with this hoplimit.
This patche removes the line such that ping6 is answered with the
hoplimit value configured via sysctl.

Signed-off-by: Thomas Egerer <thomas.egerer@secunet.com>
---
 net/ipv6/route.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)



[-- Attachment #2: 0001-ipv6-Remove-hoplimit-initialization-to-1.patch --]
[-- Type: text/x-patch, Size: 416 bytes --]

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 843406f..0a5d02a 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2012,7 +2012,6 @@ struct rt6_info *addrconf_dst_alloc(struct inet6_dev *idev,
 	rt->dst.output = ip6_output;
 	rt->rt6i_dev = net->loopback_dev;
 	rt->rt6i_idev = idev;
-	dst_metric_set(&rt->dst, RTAX_HOPLIMIT, -1);
 	rt->dst.obsolete = -1;
 
 	rt->rt6i_flags = RTF_UP | RTF_NONEXTHOP;


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipv6: Remove hoplimit initialization to -1
  2011-04-21  8:56 [PATCH] ipv6: Remove hoplimit initialization to -1 Thomas Egerer
@ 2011-04-22  0:25 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-04-22  0:25 UTC (permalink / raw)
  To: thomas.egerer; +Cc: netdev

From: Thomas Egerer <thomas.egerer@secunet.com>
Date: Thu, 21 Apr 2011 10:56:02 +0200

> 
> The changes introduced with git-commit a02e4b7d missed to remove the
> hoplimit initialization. As a result, ipv6_get_mtu interprets the return
> value of dst_metric_raw (-1) as 255 and answers ping6 with this hoplimit.
> This patche removes the line such that ping6 is answered with the
> hoplimit value configured via sysctl.
> 
> Signed-off-by: Thomas Egerer <thomas.egerer@secunet.com>

Sorry for breaking this, patch applied.

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-22  0:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-21  8:56 [PATCH] ipv6: Remove hoplimit initialization to -1 Thomas Egerer
2011-04-22  0:25 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).