From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Haley Subject: Re: [PATCH net-next-2.6] ipv4,ipv6,bonding: Restore control over number of peer notifications Date: Wed, 27 Apr 2011 10:21:17 -0400 Message-ID: <4DB8265D.2080302@hp.com> References: <1303867552.2850.39.camel@bwh-desktop> <4DB77AC2.5070207@hp.com> <1303870446.3032.399.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jay Vosburgh , Andy Gospodarek , David Miller , Patrick McHardy , netdev@vger.kernel.org To: Ben Hutchings Return-path: Received: from g1t0027.austin.hp.com ([15.216.28.34]:23681 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509Ab1D0OVV (ORCPT ); Wed, 27 Apr 2011 10:21:21 -0400 In-Reply-To: <1303870446.3032.399.camel@localhost> Sender: netdev-owner@vger.kernel.org List-ID: On 04/26/2011 10:14 PM, Ben Hutchings wrote: > On Tue, 2011-04-26 at 22:09 -0400, Brian Haley wrote: >> On 04/26/2011 09:25 PM, Ben Hutchings wrote: >>> For backward compatibility, we should retain the module parameters and >>> sysfs attributes to control the number of peer notifications >>> (gratuitous ARPs and unsolicited NAs) sent after bonding failover. >>> Also, it is possible for failover to take place even though the new >>> active slave does not have link up, and in that case the peer >>> notification should be deferred until it does. >>> >>> Change ipv4 and ipv6 so they do not automatically send peer >>> notifications on bonding failover. >>> >>> Change the bonding driver to send separate NETDEV_NOTIFY_PEERS >>> notifications when the link is up, as many times as requested. Since >>> it does not directly control which protocols send notifications, make >>> num_grat_arp and num_unsol_na aliases for a single parameter. Bump >>> the bonding version number and update its documentation. >>> >>> Signed-off-by: Ben Hutchings >> >> Signed-off-by: Brian Haley > > I'm not sure what you mean by this. You didn't write any of it and > you're not a maintainer with your own repository. Did you mean to say > 'Reviewed-by' or 'Acked-by'? Sorry, yes: Acked-by: Brian Haley