netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: "David Miller" <davem@davemloft.net>
Cc: <shemminger@linux-foundation.org>,
	<bridge@lists.linux-foundation.org>, <jeffm@suse.com>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH] bridge: Module use count must be updated as bridges are created/destroyed
Date: Fri, 29 Apr 2011 08:41:10 +0100	[thread overview]
Message-ID: <4DBA87B6020000780003ED74@vpn.id2.novell.com> (raw)
In-Reply-To: <20110429.002530.112581952.davem@davemloft.net>

>>> On 29.04.11 at 09:25, David Miller <davem@davemloft.net> wrote:
> From: "Jan Beulich" <JBeulich@novell.com>
> Date: Fri, 29 Apr 2011 08:21:14 +0100
> 
>> Otherwise 'modprobe -r' on a module having a dependency on bridge will
>> implicitly unload bridge, bringing down all connectivity that was using
>> bridges.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>> Cc: Jeff Mahoney <jeffm@suse.com>
> 
> All network device drivers behave exactly the same way, when you rmmod
> the thing we unconfigure all the routes, addresses, etc. going through
> that device and let you unload it.
> 
> And this behavior is very much intentional.
> 
> Don't add an exception here.

You talk of rmmod on the very module, but the issue is about
modprobe -r on a dependent module. I cannot believe you consider
it correct that *implicit* unloading of bridge.ko should happen when
bridges are configured.

If the solution proposed isn't satisfactory, can you suggest a better
alternative still serving the purpose?

Jan


  reply	other threads:[~2011-04-29  7:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29  7:21 [PATCH] bridge: Module use count must be updated as bridges are created/destroyed Jan Beulich
2011-04-29  7:25 ` David Miller
2011-04-29  7:41   ` Jan Beulich [this message]
2011-04-29  8:10     ` David Miller
2011-04-29  8:31       ` Jan Beulich
2011-04-29  8:44         ` David Miller
2011-04-29  9:09           ` Jan Beulich
2011-04-29 11:08             ` Michal Marek
2011-04-29 16:05               ` Jon Masters
2011-04-29 16:07                 ` Jan Beulich
2011-04-29 16:20                   ` Jon Masters
2011-04-29 15:34   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBA87B6020000780003ED74@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jeffm@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).