netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: "Jon Masters" <jonathan@jonmasters.org>
Cc: "David Miller" <davem@davemloft.net>,
	"Jon Masters" <jcm@jonmasters.org>,
	<shemminger@linux-foundation.org>,
	<bridge@lists.linux-foundation.org>, <jeffm@suse.com>,
	"Michal Marek" <mmarek@suse.cz>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] bridge: Module use count must be updated as	 bridges are created/destroyed
Date: Fri, 29 Apr 2011 17:07:01 +0100	[thread overview]
Message-ID: <4DBAFE45020000780003EEE6@vpn.id2.novell.com> (raw)
In-Reply-To: <1304093116.11627.386.camel@constitution.bos.jonmasters.org>

>>> On 29.04.11 at 18:05, Jon Masters <jonathan@jonmasters.org> wrote:
> On Fri, 2011-04-29 at 13:08 +0200, Michal Marek wrote:
>> On 29.4.2011 11:09, Jan Beulich wrote:
>> >>>> On 29.04.11 at 10:44, David Miller<davem@davemloft.net>  wrote:
> 
>> >> Nothing on the system should be hitting modules with unload requests
>> >> unless the user explicitly asked for that specific module to be
>> >> unloaded.  At least not by default.
>> >>
>> >> So the me the problem is perhaps that "modprobe -r" does this auto
>> >> dependency unloading thing by default.
>> >>
>> >> When we first fixed network device drivers so that they now properly
>> >> always run with no module refcount at all, people complained because
>> >> there were some distributions that ran some daemon that periodically
>> >> looked for "unreferenced" modules and "helped" the user by
>> >> automatically unloaded them.
>> >>
>> >> We killed that foolish daemon, and we can fix "modprobe -r" too.
>> >
>> > Michal - aren't you the modutils maintainer?
>> 
>> That would be Jon (CC added).
> 
> Thanks. So the specific feature you mention was added precisely because
> some folks wanted to clean up ununsed modules by removing all of their
> dependencies. Since I've not been on this thread until now, can you let
> me know what precisely you need, and why? We can make the unloading of
> unused modules configurable, but it sounds like you're saying even that
> isn't good enough. What actually happens, what's the bug experience?

The problem observed was that unloading (via modprobe -r)
ebtable_broute.ko, bridge.ko was also unloaded, causing all
bridged networking to stop functioning on a machine.

Jan


  reply	other threads:[~2011-04-29 16:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29  7:21 [PATCH] bridge: Module use count must be updated as bridges are created/destroyed Jan Beulich
2011-04-29  7:25 ` David Miller
2011-04-29  7:41   ` Jan Beulich
2011-04-29  8:10     ` David Miller
2011-04-29  8:31       ` Jan Beulich
2011-04-29  8:44         ` David Miller
2011-04-29  9:09           ` Jan Beulich
2011-04-29 11:08             ` Michal Marek
2011-04-29 16:05               ` Jon Masters
2011-04-29 16:07                 ` Jan Beulich [this message]
2011-04-29 16:20                   ` Jon Masters
2011-04-29 15:34   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBAFE45020000780003EEE6@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jcm@jonmasters.org \
    --cc=jeffm@suse.com \
    --cc=jonathan@jonmasters.org \
    --cc=mmarek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).